fix: Fire trackinfo for audio only transmuxers #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
commented
Jun 21, 2019
| @@ -197,9 +193,9 @@ var aacPipeline = function(options) { | |||
| return; | |||
| } | |||
|
|
|||
| pipeline.tracks.audio = { | |||
| pipeline.tracks.audio = pipeline.tracks.audio || { | |||
There was a problem hiding this comment.
Made this more like the non-partial transmuxer.
brandonocasey
commented
Jun 21, 2019
| @@ -208,19 +204,13 @@ var aacPipeline = function(options) { | |||
| // hook up the audio segment stream to the first track with aac data | |||
| pipeline.audioSegmentStream = new AudioSegmentStream(pipeline.tracks.audio, options); | |||
|
|
|||
| pipeline.audioSegmentStream.on('timingInfo', | |||
There was a problem hiding this comment.
We were firing audioTimingInfo twice, woops
brandonocasey
commented
Jun 21, 2019
| pipeline.trigger.bind(pipeline, 'audioTimingInfo')); | ||
|
|
||
| // Set up the final part of the audio pipeline | ||
| pipeline.adtsStream |
There was a problem hiding this comment.
Move the actual pipe below listener definitions just in case.
brandonocasey
commented
Jun 21, 2019
| @@ -266,6 +264,7 @@ var Transmuxer = function(options) { | |||
| hasFlushed = true; | |||
|
|
|||
| Transmuxer.prototype.init.call(this); | |||
| options.baseMediaDecodeTime = options.baseMediaDecodeTime || 0; | |||
There was a problem hiding this comment.
Without this baseMediaDecodeTime defaults to undefined, which is weird.
This was referenced Jun 21, 2019
brandonocasey
force-pushed
the
fix/audio-only-trackinfo
branch
from
2e3cc96 to
8cec3df
Compare
brandonocasey
force-pushed
the
fix/audio-only-trackinfo
branch
from
8cec3df to
7f7950d
Compare
brandonocasey
force-pushed
the
fix/audio-only-trackinfo
branch
from
7f7950d to
9b917e0
Compare
gkatsev
approved these changes
Jun 24, 2019
ldayananda
approved these changes
Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we only fire
trackinfofortsPipelines, but we should fire it foraacPipelinesas well.