fix: Return the correct buffer for each segmentloader

[brandonocasey]

With the current implementation a separate video and audio segment loader will try to use the combined buffered value, this causes all kinds of issues. For high bit rate sources we see a lot of append over max on source buffer errors.

[gkatsev]

This makes sense and seems to sort of match usage in remove().
I'd still like to test this before merging, though.

[brandonocasey]

Added the source I used for testing, although you will have to force the 4k rendition to get it to happen.

[gkatsev]

Would be nice to add the quality-levels plugin on this page as well. I added 'node_modules/videojs-contrib-quality-levels/dist/videojs-contrib-quality-levels' to the list of scripts in the change handler thingy. I then used Array.from(player.qualityLevels()).forEach(l=>l.enabled = l.height > 1000) to choose the 4k rendition

[gkatsev]

Just tested this. Without the change, I kept getting sourcebuffer is full error messages and then about 6 minutes it stalled. With this change it is playing back without any error messages.

[ldayananda]

LGTM, makes sense to me.

Edit: Did a quick test with the 4K rendition and got a lot of buffering but quick recovery and no stalls

[ldayananda]

this breaks the Netlify build, probably because videojs-contrib-quality-levels would have to be added to the devDependencies

[gkatsev]

Ah, whoops. Needs to be copied over in the netlify script

[gkatsev]

just needs to be added here

http-streaming/scripts/netlify.js

Lines 5 to 10 in 0d8eb57

	const vjs = 'node_modules/video.js/dist/alt/video.core.js';
	const vjsCss = 'node_modules/video.js/dist/video-js.css';
	const eme = 'node_modules/videojs-contrib-eme/dist/videojs-contrib-eme.js';
	const indexScript = 'scripts/index.js';
	const deployDir = 'deploy';
	const files = [vjs, vjsCss, eme, indexScript];

[brandonocasey]

interesting will do

[brandonocasey]

is there any reason that we don't just deploy out of the root project directory?

[gkatsev]

The only failing test is the live dash playback one. It is also failing unreliably, even if most of the time. When applying #545 it can reliably pass.
Going to go ahead a merge this particularly since master is frozen until all the TBA/LHLS work is in.