Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issues with the demo in ie11 and firefox #544

Merged
merged 3 commits into from
Jun 12, 2019
Merged

fix: issues with the demo in ie11 and firefox #544

merged 3 commits into from
Jun 12, 2019

Conversation

brandonocasey
Copy link
Contributor

Description

  • Adds back in url type specifier
  • Fixes issues and styling in firefox
  • fixes dispatch event in ie 11

@brandonocasey brandonocasey mentioned this pull request Jun 12, 2019
Closed
19 tasks
@brandonocasey brandonocasey added this to the TBA/LHLS milestone Jun 12, 2019
@gkatsev
Copy link
Member

gkatsev commented Jun 12, 2019

This isn't working for me locally or on netlify

gkatsev
gkatsev reviewed Jun 12, 2019
View reviewed changes
scripts/index.js Outdated Show resolved Hide resolved
@gkatsev gkatsev merged commit 0d8eb57 into master Jun 12, 2019
@gkatsev
Copy link
Member

gkatsev commented Jun 12, 2019

Tests didn't pass but no actual code that is tested was changed.

@gkatsev gkatsev deleted the fix/demo-issues branch June 12, 2019 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkatsev gkatsev gkatsev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
TBA/LHLS
Development

Successfully merging this pull request may close these issues.
2 participants
@brandonocasey @gkatsev