-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up render.tsx options #13759
Merged
kodiakhq
merged 8 commits into
vercel:canary
from
timneutkens:add/cleanup-render-options
Jun 6, 2020
Merged
Clean up render.tsx options #13759
kodiakhq
merged 8 commits into
vercel:canary
from
timneutkens:add/cleanup-render-options
Jun 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stats from current PRDefault Server Mode (Increase detected
|
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
buildDuration | 13s | 13.5s | |
nodeModulesSize | 66 MB | 66 MB | -2.14 kB |
Page Load Tests Overall increase ✓
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.277 | 2.191 | -0.09 |
/ avg req/sec | 1097.7 | 1140.98 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.472 | 1.359 | -0.11 |
/error-in-render avg req/sec | 1698.45 | 1839.66 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
main-HASH.js gzip | 6.59 kB | 6.59 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..6c2a.js gzip | 10.5 kB | 10.5 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 57 kB | 57 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
main-HASH.module.js gzip | 5.67 kB | 5.67 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..dule.js gzip | 6.93 kB | 6.93 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 52.5 kB | 52.5 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 26.3 kB | 26.3 kB | ✓ |
Overall change | 26.3 kB | 26.3 kB | ✓ |
Client Pages
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
_app.js gzip | 1.26 kB | 1.26 kB | ✓ |
_error.js gzip | 3.25 kB | 3.25 kB | ✓ |
hooks.js gzip | 881 B | 881 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.05 kB | 2.05 kB | ✓ |
routerDirect.js gzip | 279 B | 279 B | ✓ |
withRouter.js gzip | 278 B | 278 B | ✓ |
Overall change | 8.21 kB | 8.21 kB | ✓ |
Client Pages Modern
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
_app.module.js gzip | 604 B | 604 B | ✓ |
_error.module.js gzip | 2.04 kB | 2.04 kB | ✓ |
hooks.module.js gzip | 383 B | 383 B | ✓ |
index.module.js gzip | 223 B | 223 B | ✓ |
link.module.js gzip | 1.51 kB | 1.51 kB | ✓ |
routerDirect..dule.js gzip | 281 B | 281 B | ✓ |
withRouter.m..dule.js gzip | 278 B | 278 B | ✓ |
Overall change | 5.32 kB | 5.32 kB | ✓ |
Client Build Manifests
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
index.html gzip | 924 B | 924 B | ✓ |
link.html gzip | 934 B | 934 B | ✓ |
withRouter.html gzip | 922 B | 922 B | ✓ |
Overall change | 2.78 kB | 2.78 kB | ✓ |
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
buildDuration | 14.6s | 14.9s | |
nodeModulesSize | 66 MB | 66 MB | -2.14 kB |
Client Bundles (main, webpack, commons)
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
main-HASH.js gzip | 6.59 kB | 6.59 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..6c2a.js gzip | 10.5 kB | 10.5 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 57 kB | 57 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
main-HASH.module.js gzip | 5.67 kB | 5.67 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..dule.js gzip | 6.93 kB | 6.93 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 52.5 kB | 52.5 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 26.3 kB | 26.3 kB | ✓ |
Overall change | 26.3 kB | 26.3 kB | ✓ |
Client Pages
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
_app.js gzip | 1.26 kB | 1.26 kB | ✓ |
_error.js gzip | 3.25 kB | 3.25 kB | ✓ |
hooks.js gzip | 881 B | 881 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.05 kB | 2.05 kB | ✓ |
routerDirect.js gzip | 279 B | 279 B | ✓ |
withRouter.js gzip | 278 B | 278 B | ✓ |
Overall change | 8.21 kB | 8.21 kB | ✓ |
Client Pages Modern
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
_app.module.js gzip | 604 B | 604 B | ✓ |
_error.module.js gzip | 2.04 kB | 2.04 kB | ✓ |
hooks.module.js gzip | 383 B | 383 B | ✓ |
index.module.js gzip | 223 B | 223 B | ✓ |
link.module.js gzip | 1.51 kB | 1.51 kB | ✓ |
routerDirect..dule.js gzip | 281 B | 281 B | ✓ |
withRouter.m..dule.js gzip | 278 B | 278 B | ✓ |
Overall change | 5.32 kB | 5.32 kB | ✓ |
Client Build Manifests
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall decrease ✓
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
_error.js | 878 kB | 878 kB | -419 B |
404.html | 4.18 kB | 4.18 kB | ✓ |
hooks.html | 3.81 kB | 3.81 kB | ✓ |
index.js | 879 kB | 878 kB | -419 B |
link.js | 916 kB | 916 kB | -419 B |
routerDirect.js | 909 kB | 908 kB | -419 B |
withRouter.js | 909 kB | 908 kB | -419 B |
Overall change | 4.5 MB | 4.5 MB | -2.1 kB |
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall decrease ✓
Page Load Tests Overall decrease
|
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 1.955 | 1.942 | -0.01 |
/ avg req/sec | 1278.83 | 1287.6 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.135 | 1.152 | |
/error-in-render avg req/sec | 2202.77 | 2170.23 | -32.54 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
main-HASH.js gzip | 6.59 kB | 6.59 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..6c2a.js gzip | 10.5 kB | 10.5 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 57 kB | 57 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
main-HASH.module.js gzip | 5.67 kB | 5.67 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..dule.js gzip | 6.93 kB | 6.93 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 52.5 kB | 52.5 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 26.3 kB | 26.3 kB | ✓ |
Overall change | 26.3 kB | 26.3 kB | ✓ |
Client Pages
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
_app.js gzip | 1.26 kB | 1.26 kB | ✓ |
_error.js gzip | 3.25 kB | 3.25 kB | ✓ |
hooks.js gzip | 881 B | 881 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.05 kB | 2.05 kB | ✓ |
routerDirect.js gzip | 279 B | 279 B | ✓ |
withRouter.js gzip | 278 B | 278 B | ✓ |
Overall change | 8.21 kB | 8.21 kB | ✓ |
Client Pages Modern
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
_app.module.js gzip | 604 B | 604 B | ✓ |
_error.module.js gzip | 2.04 kB | 2.04 kB | ✓ |
hooks.module.js gzip | 383 B | 383 B | ✓ |
index.module.js gzip | 223 B | 223 B | ✓ |
link.module.js gzip | 1.51 kB | 1.51 kB | ✓ |
routerDirect..dule.js gzip | 281 B | 281 B | ✓ |
withRouter.m..dule.js gzip | 278 B | 278 B | ✓ |
Overall change | 5.32 kB | 5.32 kB | ✓ |
Client Build Manifests
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
index.html gzip | 924 B | 924 B | ✓ |
link.html gzip | 934 B | 934 B | ✓ |
withRouter.html gzip | 922 B | 922 B | ✓ |
Overall change | 2.78 kB | 2.78 kB | ✓ |
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
buildDuration | 12.6s | 12.4s | -207ms |
nodeModulesSize | 66 MB | 66 MB | -5.06 kB |
Client Bundles (main, webpack, commons)
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
main-HASH.js gzip | 6.59 kB | 6.59 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..6c2a.js gzip | 10.5 kB | 10.5 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 57 kB | 57 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
main-HASH.module.js gzip | 5.67 kB | 5.67 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..dule.js gzip | 6.93 kB | 6.93 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 52.5 kB | 52.5 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 26.3 kB | 26.3 kB | ✓ |
Overall change | 26.3 kB | 26.3 kB | ✓ |
Client Pages
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
_app.js gzip | 1.26 kB | 1.26 kB | ✓ |
_error.js gzip | 3.25 kB | 3.25 kB | ✓ |
hooks.js gzip | 881 B | 881 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.05 kB | 2.05 kB | ✓ |
routerDirect.js gzip | 279 B | 279 B | ✓ |
withRouter.js gzip | 278 B | 278 B | ✓ |
Overall change | 8.21 kB | 8.21 kB | ✓ |
Client Pages Modern
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
_app.module.js gzip | 604 B | 604 B | ✓ |
_error.module.js gzip | 2.04 kB | 2.04 kB | ✓ |
hooks.module.js gzip | 383 B | 383 B | ✓ |
index.module.js gzip | 223 B | 223 B | ✓ |
link.module.js gzip | 1.51 kB | 1.51 kB | ✓ |
routerDirect..dule.js gzip | 281 B | 281 B | ✓ |
withRouter.m..dule.js gzip | 278 B | 278 B | ✓ |
Overall change | 5.32 kB | 5.32 kB | ✓ |
Client Build Manifests
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall decrease ✓
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
_error.js | 878 kB | 877 kB | -983 B |
404.html | 4.18 kB | 4.18 kB | ✓ |
hooks.html | 3.81 kB | 3.81 kB | ✓ |
index.js | 879 kB | 878 kB | -983 B |
link.js | 916 kB | 915 kB | -983 B |
routerDirect.js | 909 kB | 908 kB | -983 B |
withRouter.js | 909 kB | 908 kB | -983 B |
Overall change | 4.5 MB | 4.49 MB | -4.92 kB |
Stats from current PRDefault Server Mode (Increase detected
|
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
buildDuration | 13.8s | 12.7s | -1.1s |
nodeModulesSize | 66 MB | 66 MB | -3.76 kB |
Page Load Tests Overall increase ✓
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.332 | 2.219 | -0.11 |
/ avg req/sec | 1071.83 | 1126.69 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.545 | 1.504 | -0.04 |
/error-in-render avg req/sec | 1617.96 | 1662.72 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
main-HASH.js gzip | 6.59 kB | 6.59 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..6c2a.js gzip | 10.5 kB | 10.5 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 57 kB | 57 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
main-HASH.module.js gzip | 5.67 kB | 5.67 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..dule.js gzip | 6.93 kB | 6.93 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 52.5 kB | 52.5 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 26.3 kB | 26.3 kB | ✓ |
Overall change | 26.3 kB | 26.3 kB | ✓ |
Client Pages
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
_app.js gzip | 1.26 kB | 1.26 kB | ✓ |
_error.js gzip | 3.25 kB | 3.25 kB | ✓ |
hooks.js gzip | 881 B | 881 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.05 kB | 2.05 kB | ✓ |
routerDirect.js gzip | 279 B | 279 B | ✓ |
withRouter.js gzip | 278 B | 278 B | ✓ |
Overall change | 8.21 kB | 8.21 kB | ✓ |
Client Pages Modern
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
_app.module.js gzip | 604 B | 604 B | ✓ |
_error.module.js gzip | 2.04 kB | 2.04 kB | ✓ |
hooks.module.js gzip | 383 B | 383 B | ✓ |
index.module.js gzip | 223 B | 223 B | ✓ |
link.module.js gzip | 1.51 kB | 1.51 kB | ✓ |
routerDirect..dule.js gzip | 281 B | 281 B | ✓ |
withRouter.m..dule.js gzip | 278 B | 278 B | ✓ |
Overall change | 5.32 kB | 5.32 kB | ✓ |
Client Build Manifests
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
index.html gzip | 924 B | 925 B | |
link.html gzip | 934 B | 935 B | |
withRouter.html gzip | 922 B | 923 B | |
Overall change | 2.78 kB | 2.78 kB |
Diffs
Diff for index.html
@@ -36,7 +36,7 @@
/>
<link
rel="preload"
- href="/_next/static/runtime/main-5062a6ab83d04dfd16c2.module.js"
+ href="/_next/static/runtime/main-d07b14d6f5c5f22c9f78.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -145,13 +145,13 @@
type="module"
></script>
<script
- src="/_next/static/runtime/main-750a8131bb83360bfd80.js"
+ src="/_next/static/runtime/main-8ef6b7eed3c66aee8c95.js"
async=""
crossorigin="anonymous"
nomodule=""
></script>
<script
- src="/_next/static/runtime/main-5062a6ab83d04dfd16c2.module.js"
+ src="/_next/static/runtime/main-d07b14d6f5c5f22c9f78.module.js"
async=""
crossorigin="anonymous"
type="module"
Diff for link.html
@@ -36,7 +36,7 @@
/>
<link
rel="preload"
- href="/_next/static/runtime/main-5062a6ab83d04dfd16c2.module.js"
+ href="/_next/static/runtime/main-d07b14d6f5c5f22c9f78.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -150,13 +150,13 @@
type="module"
></script>
<script
- src="/_next/static/runtime/main-750a8131bb83360bfd80.js"
+ src="/_next/static/runtime/main-8ef6b7eed3c66aee8c95.js"
async=""
crossorigin="anonymous"
nomodule=""
></script>
<script
- src="/_next/static/runtime/main-5062a6ab83d04dfd16c2.module.js"
+ src="/_next/static/runtime/main-d07b14d6f5c5f22c9f78.module.js"
async=""
crossorigin="anonymous"
type="module"
Diff for withRouter.html
@@ -36,7 +36,7 @@
/>
<link
rel="preload"
- href="/_next/static/runtime/main-5062a6ab83d04dfd16c2.module.js"
+ href="/_next/static/runtime/main-d07b14d6f5c5f22c9f78.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -145,13 +145,13 @@
type="module"
></script>
<script
- src="/_next/static/runtime/main-750a8131bb83360bfd80.js"
+ src="/_next/static/runtime/main-8ef6b7eed3c66aee8c95.js"
async=""
crossorigin="anonymous"
nomodule=""
></script>
<script
- src="/_next/static/runtime/main-5062a6ab83d04dfd16c2.module.js"
+ src="/_next/static/runtime/main-d07b14d6f5c5f22c9f78.module.js"
async=""
crossorigin="anonymous"
type="module"
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
buildDuration | 14.3s | 14s | -248ms |
nodeModulesSize | 66 MB | 66 MB | -3.76 kB |
Client Bundles (main, webpack, commons)
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
main-HASH.js gzip | 6.59 kB | 6.59 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..6c2a.js gzip | 10.5 kB | 10.5 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 57 kB | 57 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
main-HASH.module.js gzip | 5.67 kB | 5.67 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..dule.js gzip | 6.93 kB | 6.93 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 52.5 kB | 52.5 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 26.3 kB | 26.3 kB | ✓ |
Overall change | 26.3 kB | 26.3 kB | ✓ |
Client Pages
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
_app.js gzip | 1.26 kB | 1.26 kB | ✓ |
_error.js gzip | 3.25 kB | 3.25 kB | ✓ |
hooks.js gzip | 881 B | 881 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.05 kB | 2.05 kB | ✓ |
routerDirect.js gzip | 279 B | 279 B | ✓ |
withRouter.js gzip | 278 B | 278 B | ✓ |
Overall change | 8.21 kB | 8.21 kB | ✓ |
Client Pages Modern
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
_app.module.js gzip | 604 B | 604 B | ✓ |
_error.module.js gzip | 2.04 kB | 2.04 kB | ✓ |
hooks.module.js gzip | 383 B | 383 B | ✓ |
index.module.js gzip | 223 B | 223 B | ✓ |
link.module.js gzip | 1.51 kB | 1.51 kB | ✓ |
routerDirect..dule.js gzip | 281 B | 281 B | ✓ |
withRouter.m..dule.js gzip | 278 B | 278 B | ✓ |
Overall change | 5.32 kB | 5.32 kB | ✓ |
Client Build Manifests
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall decrease ✓
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
_error.js | 878 kB | 877 kB | -983 B |
404.html | 4.18 kB | 4.18 kB | ✓ |
hooks.html | 3.81 kB | 3.81 kB | ✓ |
index.js | 879 kB | 878 kB | -983 B |
link.js | 916 kB | 915 kB | -983 B |
routerDirect.js | 909 kB | 908 kB | -983 B |
withRouter.js | 909 kB | 908 kB | -983 B |
Overall change | 4.5 MB | 4.49 MB | -4.92 kB |
Stats from current PRDefault Server Mode (Increase detected
|
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
buildDuration | 11.2s | 11.6s | |
nodeModulesSize | 66 MB | 66 MB | -4.68 kB |
Page Load Tests Overall increase ✓
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.045 | 1.967 | -0.08 |
/ avg req/sec | 1222.21 | 1270.93 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.287 | 1.302 | |
/error-in-render avg req/sec | 1943 | 1920.2 | -22.8 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
main-HASH.js gzip | 6.61 kB | 6.61 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..9545.js gzip | 10.5 kB | 10.5 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 57 kB | 57 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
main-HASH.module.js gzip | 5.69 kB | 5.69 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..dule.js gzip | 6.92 kB | 6.92 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 52.5 kB | 52.5 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 26.3 kB | 26.3 kB | ✓ |
Overall change | 26.3 kB | 26.3 kB | ✓ |
Client Pages
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
_app.js gzip | 1.26 kB | 1.26 kB | ✓ |
_error.js gzip | 3.25 kB | 3.25 kB | ✓ |
hooks.js gzip | 881 B | 881 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.05 kB | 2.05 kB | ✓ |
routerDirect.js gzip | 279 B | 279 B | ✓ |
withRouter.js gzip | 278 B | 278 B | ✓ |
Overall change | 8.21 kB | 8.21 kB | ✓ |
Client Pages Modern
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
_app.module.js gzip | 604 B | 604 B | ✓ |
_error.module.js gzip | 2.04 kB | 2.04 kB | ✓ |
hooks.module.js gzip | 383 B | 383 B | ✓ |
index.module.js gzip | 223 B | 223 B | ✓ |
link.module.js gzip | 1.51 kB | 1.51 kB | ✓ |
routerDirect..dule.js gzip | 281 B | 281 B | ✓ |
withRouter.m..dule.js gzip | 278 B | 278 B | ✓ |
Overall change | 5.32 kB | 5.32 kB | ✓ |
Client Build Manifests
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
index.html gzip | 927 B | 926 B | -1 B |
link.html gzip | 936 B | 936 B | ✓ |
withRouter.html gzip | 924 B | 923 B | -1 B |
Overall change | 2.79 kB | 2.79 kB | -2 B |
Diffs
Diff for index.html
@@ -36,7 +36,7 @@
/>
<link
rel="preload"
- href="/_next/static/runtime/main-937ebff178d890c328e4.module.js"
+ href="/_next/static/runtime/main-9983e7815e3ba06ad77d.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -145,13 +145,13 @@
type="module"
></script>
<script
- src="/_next/static/runtime/main-4fb3b973e7d6059591cd.js"
+ src="/_next/static/runtime/main-33619d3e0ab7357d825b.js"
async=""
crossorigin="anonymous"
nomodule=""
></script>
<script
- src="/_next/static/runtime/main-937ebff178d890c328e4.module.js"
+ src="/_next/static/runtime/main-9983e7815e3ba06ad77d.module.js"
async=""
crossorigin="anonymous"
type="module"
Diff for link.html
@@ -36,7 +36,7 @@
/>
<link
rel="preload"
- href="/_next/static/runtime/main-937ebff178d890c328e4.module.js"
+ href="/_next/static/runtime/main-9983e7815e3ba06ad77d.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -150,13 +150,13 @@
type="module"
></script>
<script
- src="/_next/static/runtime/main-4fb3b973e7d6059591cd.js"
+ src="/_next/static/runtime/main-33619d3e0ab7357d825b.js"
async=""
crossorigin="anonymous"
nomodule=""
></script>
<script
- src="/_next/static/runtime/main-937ebff178d890c328e4.module.js"
+ src="/_next/static/runtime/main-9983e7815e3ba06ad77d.module.js"
async=""
crossorigin="anonymous"
type="module"
Diff for withRouter.html
@@ -36,7 +36,7 @@
/>
<link
rel="preload"
- href="/_next/static/runtime/main-937ebff178d890c328e4.module.js"
+ href="/_next/static/runtime/main-9983e7815e3ba06ad77d.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -145,13 +145,13 @@
type="module"
></script>
<script
- src="/_next/static/runtime/main-4fb3b973e7d6059591cd.js"
+ src="/_next/static/runtime/main-33619d3e0ab7357d825b.js"
async=""
crossorigin="anonymous"
nomodule=""
></script>
<script
- src="/_next/static/runtime/main-937ebff178d890c328e4.module.js"
+ src="/_next/static/runtime/main-9983e7815e3ba06ad77d.module.js"
async=""
crossorigin="anonymous"
type="module"
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
buildDuration | 12.5s | 12.4s | -141ms |
nodeModulesSize | 66 MB | 66 MB | -4.68 kB |
Client Bundles (main, webpack, commons)
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
main-HASH.js gzip | 6.61 kB | 6.61 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..9545.js gzip | 10.5 kB | 10.5 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 57 kB | 57 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
main-HASH.module.js gzip | 5.69 kB | 5.69 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..dule.js gzip | 6.92 kB | 6.92 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 52.5 kB | 52.5 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 26.3 kB | 26.3 kB | ✓ |
Overall change | 26.3 kB | 26.3 kB | ✓ |
Client Pages
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
_app.js gzip | 1.26 kB | 1.26 kB | ✓ |
_error.js gzip | 3.25 kB | 3.25 kB | ✓ |
hooks.js gzip | 881 B | 881 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.05 kB | 2.05 kB | ✓ |
routerDirect.js gzip | 279 B | 279 B | ✓ |
withRouter.js gzip | 278 B | 278 B | ✓ |
Overall change | 8.21 kB | 8.21 kB | ✓ |
Client Pages Modern
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
_app.module.js gzip | 604 B | 604 B | ✓ |
_error.module.js gzip | 2.04 kB | 2.04 kB | ✓ |
hooks.module.js gzip | 383 B | 383 B | ✓ |
index.module.js gzip | 223 B | 223 B | ✓ |
link.module.js gzip | 1.51 kB | 1.51 kB | ✓ |
routerDirect..dule.js gzip | 281 B | 281 B | ✓ |
withRouter.m..dule.js gzip | 278 B | 278 B | ✓ |
Overall change | 5.32 kB | 5.32 kB | ✓ |
Client Build Manifests
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall decrease ✓
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
_error.js | 878 kB | 877 kB | -1.21 kB |
404.html | 4.18 kB | 4.18 kB | ✓ |
hooks.html | 3.81 kB | 3.81 kB | ✓ |
index.js | 878 kB | 877 kB | -1.21 kB |
link.js | 916 kB | 915 kB | -1.21 kB |
routerDirect.js | 909 kB | 907 kB | -1.21 kB |
withRouter.js | 909 kB | 907 kB | -1.21 kB |
Overall change | 4.5 MB | 4.49 MB | -6.03 kB |
Stats from current PRDefault Server Mode (Increase detected
|
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
buildDuration | 12.7s | 12.8s | |
nodeModulesSize | 66 MB | 66 MB | -5.86 kB |
Page Load Tests Overall increase ✓
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.235 | 2.2 | -0.03 |
/ avg req/sec | 1118.56 | 1136.44 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.494 | 1.46 | -0.03 |
/error-in-render avg req/sec | 1673.89 | 1712.03 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
main-HASH.js gzip | 6.61 kB | 6.61 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..9545.js gzip | 10.5 kB | 10.5 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 57 kB | 57 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
main-HASH.module.js gzip | 5.69 kB | 5.69 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..dule.js gzip | 6.92 kB | 6.92 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 52.5 kB | 52.5 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 26.3 kB | 26.3 kB | ✓ |
Overall change | 26.3 kB | 26.3 kB | ✓ |
Client Pages
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
_app.js gzip | 1.26 kB | 1.26 kB | ✓ |
_error.js gzip | 3.25 kB | 3.25 kB | ✓ |
hooks.js gzip | 881 B | 881 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.05 kB | 2.05 kB | ✓ |
routerDirect.js gzip | 279 B | 279 B | ✓ |
withRouter.js gzip | 278 B | 278 B | ✓ |
Overall change | 8.21 kB | 8.21 kB | ✓ |
Client Pages Modern
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
_app.module.js gzip | 604 B | 604 B | ✓ |
_error.module.js gzip | 2.04 kB | 2.04 kB | ✓ |
hooks.module.js gzip | 383 B | 383 B | ✓ |
index.module.js gzip | 223 B | 223 B | ✓ |
link.module.js gzip | 1.51 kB | 1.51 kB | ✓ |
routerDirect..dule.js gzip | 281 B | 281 B | ✓ |
withRouter.m..dule.js gzip | 278 B | 278 B | ✓ |
Overall change | 5.32 kB | 5.32 kB | ✓ |
Client Build Manifests
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
index.html gzip | 927 B | 926 B | -1 B |
link.html gzip | 936 B | 936 B | ✓ |
withRouter.html gzip | 924 B | 923 B | -1 B |
Overall change | 2.79 kB | 2.79 kB | -2 B |
Diffs
Diff for index.html
@@ -36,7 +36,7 @@
/>
<link
rel="preload"
- href="/_next/static/runtime/main-937ebff178d890c328e4.module.js"
+ href="/_next/static/runtime/main-9983e7815e3ba06ad77d.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -145,13 +145,13 @@
type="module"
></script>
<script
- src="/_next/static/runtime/main-4fb3b973e7d6059591cd.js"
+ src="/_next/static/runtime/main-33619d3e0ab7357d825b.js"
async=""
crossorigin="anonymous"
nomodule=""
></script>
<script
- src="/_next/static/runtime/main-937ebff178d890c328e4.module.js"
+ src="/_next/static/runtime/main-9983e7815e3ba06ad77d.module.js"
async=""
crossorigin="anonymous"
type="module"
Diff for link.html
@@ -36,7 +36,7 @@
/>
<link
rel="preload"
- href="/_next/static/runtime/main-937ebff178d890c328e4.module.js"
+ href="/_next/static/runtime/main-9983e7815e3ba06ad77d.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -150,13 +150,13 @@
type="module"
></script>
<script
- src="/_next/static/runtime/main-4fb3b973e7d6059591cd.js"
+ src="/_next/static/runtime/main-33619d3e0ab7357d825b.js"
async=""
crossorigin="anonymous"
nomodule=""
></script>
<script
- src="/_next/static/runtime/main-937ebff178d890c328e4.module.js"
+ src="/_next/static/runtime/main-9983e7815e3ba06ad77d.module.js"
async=""
crossorigin="anonymous"
type="module"
Diff for withRouter.html
@@ -36,7 +36,7 @@
/>
<link
rel="preload"
- href="/_next/static/runtime/main-937ebff178d890c328e4.module.js"
+ href="/_next/static/runtime/main-9983e7815e3ba06ad77d.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -145,13 +145,13 @@
type="module"
></script>
<script
- src="/_next/static/runtime/main-4fb3b973e7d6059591cd.js"
+ src="/_next/static/runtime/main-33619d3e0ab7357d825b.js"
async=""
crossorigin="anonymous"
nomodule=""
></script>
<script
- src="/_next/static/runtime/main-937ebff178d890c328e4.module.js"
+ src="/_next/static/runtime/main-9983e7815e3ba06ad77d.module.js"
async=""
crossorigin="anonymous"
type="module"
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
buildDuration | 13.9s | 13.7s | -156ms |
nodeModulesSize | 66 MB | 66 MB | -5.86 kB |
Client Bundles (main, webpack, commons)
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
main-HASH.js gzip | 6.61 kB | 6.61 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..9545.js gzip | 10.5 kB | 10.5 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 57 kB | 57 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
main-HASH.module.js gzip | 5.69 kB | 5.69 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..dule.js gzip | 6.92 kB | 6.92 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 52.5 kB | 52.5 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 26.3 kB | 26.3 kB | ✓ |
Overall change | 26.3 kB | 26.3 kB | ✓ |
Client Pages
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
_app.js gzip | 1.26 kB | 1.26 kB | ✓ |
_error.js gzip | 3.25 kB | 3.25 kB | ✓ |
hooks.js gzip | 881 B | 881 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.05 kB | 2.05 kB | ✓ |
routerDirect.js gzip | 279 B | 279 B | ✓ |
withRouter.js gzip | 278 B | 278 B | ✓ |
Overall change | 8.21 kB | 8.21 kB | ✓ |
Client Pages Modern
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
_app.module.js gzip | 604 B | 604 B | ✓ |
_error.module.js gzip | 2.04 kB | 2.04 kB | ✓ |
hooks.module.js gzip | 383 B | 383 B | ✓ |
index.module.js gzip | 223 B | 223 B | ✓ |
link.module.js gzip | 1.51 kB | 1.51 kB | ✓ |
routerDirect..dule.js gzip | 281 B | 281 B | ✓ |
withRouter.m..dule.js gzip | 278 B | 278 B | ✓ |
Overall change | 5.32 kB | 5.32 kB | ✓ |
Client Build Manifests
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall decrease ✓
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
_error.js | 878 kB | 877 kB | -1.21 kB |
404.html | 4.18 kB | 4.18 kB | ✓ |
hooks.html | 3.81 kB | 3.81 kB | ✓ |
index.js | 878 kB | 877 kB | -1.21 kB |
link.js | 916 kB | 915 kB | -1.21 kB |
routerDirect.js | 909 kB | 907 kB | -1.21 kB |
withRouter.js | 909 kB | 907 kB | -1.21 kB |
Overall change | 4.5 MB | 4.49 MB | -6.03 kB |
Timer
approved these changes
Jun 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Stats from current PRDefault Server Mode (Increase detected
|
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
buildDuration | 13.5s | 13.5s | |
nodeModulesSize | 66 MB | 66 MB | -5.86 kB |
Page Load Tests Overall increase ✓
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.349 | 2.345 | 0 |
/ avg req/sec | 1064.35 | 1066.03 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.515 | 1.511 | 0 |
/error-in-render avg req/sec | 1649.85 | 1654.47 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
main-HASH.js gzip | 6.61 kB | 6.61 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..9545.js gzip | 10.5 kB | 10.5 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 57 kB | 57 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
main-HASH.module.js gzip | 5.69 kB | 5.69 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..dule.js gzip | 6.92 kB | 6.92 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 52.5 kB | 52.5 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 26.3 kB | 26.3 kB | ✓ |
Overall change | 26.3 kB | 26.3 kB | ✓ |
Client Pages
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
_app.js gzip | 1.26 kB | 1.26 kB | ✓ |
_error.js gzip | 3.25 kB | 3.25 kB | ✓ |
hooks.js gzip | 881 B | 881 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.05 kB | 2.05 kB | ✓ |
routerDirect.js gzip | 279 B | 279 B | ✓ |
withRouter.js gzip | 278 B | 278 B | ✓ |
Overall change | 8.21 kB | 8.21 kB | ✓ |
Client Pages Modern
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
_app.module.js gzip | 604 B | 604 B | ✓ |
_error.module.js gzip | 2.04 kB | 2.04 kB | ✓ |
hooks.module.js gzip | 383 B | 383 B | ✓ |
index.module.js gzip | 223 B | 223 B | ✓ |
link.module.js gzip | 1.51 kB | 1.51 kB | ✓ |
routerDirect..dule.js gzip | 281 B | 281 B | ✓ |
withRouter.m..dule.js gzip | 278 B | 278 B | ✓ |
Overall change | 5.32 kB | 5.32 kB | ✓ |
Client Build Manifests
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
index.html gzip | 927 B | 926 B | -1 B |
link.html gzip | 936 B | 936 B | ✓ |
withRouter.html gzip | 924 B | 923 B | -1 B |
Overall change | 2.79 kB | 2.79 kB | -2 B |
Diffs
Diff for index.html
@@ -36,7 +36,7 @@
/>
<link
rel="preload"
- href="/_next/static/runtime/main-937ebff178d890c328e4.module.js"
+ href="/_next/static/runtime/main-9983e7815e3ba06ad77d.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -145,13 +145,13 @@
type="module"
></script>
<script
- src="/_next/static/runtime/main-4fb3b973e7d6059591cd.js"
+ src="/_next/static/runtime/main-33619d3e0ab7357d825b.js"
async=""
crossorigin="anonymous"
nomodule=""
></script>
<script
- src="/_next/static/runtime/main-937ebff178d890c328e4.module.js"
+ src="/_next/static/runtime/main-9983e7815e3ba06ad77d.module.js"
async=""
crossorigin="anonymous"
type="module"
Diff for link.html
@@ -36,7 +36,7 @@
/>
<link
rel="preload"
- href="/_next/static/runtime/main-937ebff178d890c328e4.module.js"
+ href="/_next/static/runtime/main-9983e7815e3ba06ad77d.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -150,13 +150,13 @@
type="module"
></script>
<script
- src="/_next/static/runtime/main-4fb3b973e7d6059591cd.js"
+ src="/_next/static/runtime/main-33619d3e0ab7357d825b.js"
async=""
crossorigin="anonymous"
nomodule=""
></script>
<script
- src="/_next/static/runtime/main-937ebff178d890c328e4.module.js"
+ src="/_next/static/runtime/main-9983e7815e3ba06ad77d.module.js"
async=""
crossorigin="anonymous"
type="module"
Diff for withRouter.html
@@ -36,7 +36,7 @@
/>
<link
rel="preload"
- href="/_next/static/runtime/main-937ebff178d890c328e4.module.js"
+ href="/_next/static/runtime/main-9983e7815e3ba06ad77d.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -145,13 +145,13 @@
type="module"
></script>
<script
- src="/_next/static/runtime/main-4fb3b973e7d6059591cd.js"
+ src="/_next/static/runtime/main-33619d3e0ab7357d825b.js"
async=""
crossorigin="anonymous"
nomodule=""
></script>
<script
- src="/_next/static/runtime/main-937ebff178d890c328e4.module.js"
+ src="/_next/static/runtime/main-9983e7815e3ba06ad77d.module.js"
async=""
crossorigin="anonymous"
type="module"
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
buildDuration | 14.4s | 14.6s | |
nodeModulesSize | 66 MB | 66 MB | -5.86 kB |
Client Bundles (main, webpack, commons)
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
main-HASH.js gzip | 6.61 kB | 6.61 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..9545.js gzip | 10.5 kB | 10.5 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 57 kB | 57 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
main-HASH.module.js gzip | 5.69 kB | 5.69 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..dule.js gzip | 6.92 kB | 6.92 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 52.5 kB | 52.5 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 26.3 kB | 26.3 kB | ✓ |
Overall change | 26.3 kB | 26.3 kB | ✓ |
Client Pages
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
_app.js gzip | 1.26 kB | 1.26 kB | ✓ |
_error.js gzip | 3.25 kB | 3.25 kB | ✓ |
hooks.js gzip | 881 B | 881 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.05 kB | 2.05 kB | ✓ |
routerDirect.js gzip | 279 B | 279 B | ✓ |
withRouter.js gzip | 278 B | 278 B | ✓ |
Overall change | 8.21 kB | 8.21 kB | ✓ |
Client Pages Modern
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
_app.module.js gzip | 604 B | 604 B | ✓ |
_error.module.js gzip | 2.04 kB | 2.04 kB | ✓ |
hooks.module.js gzip | 383 B | 383 B | ✓ |
index.module.js gzip | 223 B | 223 B | ✓ |
link.module.js gzip | 1.51 kB | 1.51 kB | ✓ |
routerDirect..dule.js gzip | 281 B | 281 B | ✓ |
withRouter.m..dule.js gzip | 278 B | 278 B | ✓ |
Overall change | 5.32 kB | 5.32 kB | ✓ |
Client Build Manifests
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall decrease ✓
vercel/next.js canary | timneutkens/next.js add/cleanup-render-options | Change | |
---|---|---|---|
_error.js | 878 kB | 877 kB | -1.21 kB |
404.html | 4.18 kB | 4.18 kB | ✓ |
hooks.html | 3.81 kB | 3.81 kB | ✓ |
index.js | 878 kB | 877 kB | -1.21 kB |
link.js | 916 kB | 915 kB | -1.21 kB |
routerDirect.js | 909 kB | 907 kB | -1.21 kB |
withRouter.js | 909 kB | 907 kB | -1.21 kB |
Overall change | 4.5 MB | 4.49 MB | -6.03 kB |
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 20, 2020
Updates the way filenames are generated for browser compilation. Notably: - All entry bundles now have hashes in production, this includes pages (previously pages used a buildId in the path) - The AmpFiles no longer depends on hardcoded bundle names, it uses the buildManifest instead (internals) - All cases where we match the page name from the chunk/entrypoint name now use the same function `getRouteFromEntrypoint` (internals) - In development we no longer include the "faked" `buildId` set to `development` for page files, instead we just use the `/_next/static/pages` path (was `/_next/static/development/pages`). This was changed as it caused unneeded complexity and makes generating the bundles easier (internals) - Updated tons of tests to be more resilient to these changes by relying on the buildManifest instead of hardcoded paths (internals) Follow up of these PRs: #13759 #13870 #13937 #14130 #14176 #14268 Fixes #6303 Fixes #12087 Fixes #1948 Fixes #4368 Fixes #4255 Fixes #2548
9 tasks
rokinsky
pushed a commit
to rokinsky/next.js
that referenced
this pull request
Jul 11, 2020
Went through and removed a bunch of internal options which are just pass-through values of buildManifest Closes vercel#13851
rokinsky
pushed a commit
to rokinsky/next.js
that referenced
this pull request
Jul 11, 2020
Updates the way filenames are generated for browser compilation. Notably: - All entry bundles now have hashes in production, this includes pages (previously pages used a buildId in the path) - The AmpFiles no longer depends on hardcoded bundle names, it uses the buildManifest instead (internals) - All cases where we match the page name from the chunk/entrypoint name now use the same function `getRouteFromEntrypoint` (internals) - In development we no longer include the "faked" `buildId` set to `development` for page files, instead we just use the `/_next/static/pages` path (was `/_next/static/development/pages`). This was changed as it caused unneeded complexity and makes generating the bundles easier (internals) - Updated tons of tests to be more resilient to these changes by relying on the buildManifest instead of hardcoded paths (internals) Follow up of these PRs: vercel#13759 vercel#13870 vercel#13937 vercel#14130 vercel#14176 vercel#14268 Fixes vercel#6303 Fixes vercel#12087 Fixes vercel#1948 Fixes vercel#4368 Fixes vercel#4255 Fixes vercel#2548
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Went through and removed a bunch of internal options which are just pass-through values of buildManifest
Closes #13851