Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up render.tsx options #13851

Closed
Timer opened this issue Jun 6, 2020 · 1 comment · Fixed by #13759
Closed

Clean up render.tsx options #13851

Timer opened this issue Jun 6, 2020 · 1 comment · Fixed by #13759
Assignees
@timneutkens
Milestone
june 2020

Comments

@Timer
Copy link
Member

Timer commented Jun 6, 2020

We should clean up some of the rendering pipeline code to make it easier to understand.
@Timer Timer added the point: 3 label Jun 6, 2020
@timneutkens timneutkens mentioned this issue Jun 6, 2020
Merged
@kodiakhq kodiakhq bot closed this as completed in #13759 Jun 6, 2020
kodiakhq bot pushed a commit that referenced this issue Jun 6, 2020
@timneutkens
Clean up render.tsx options (#13759)
e125d90 
Went through and removed a bunch of internal options which are just pass-through values of buildManifest

Closes #13851
@Timer Timer added this to the june 2020 milestone Jun 6, 2020
rokinsky pushed a commit to rokinsky/next.js that referenced this issue Jul 11, 2020
@timneutkens @rokinsky
Clean up render.tsx options (vercel#13759)
28dc5a2 
Went through and removed a bunch of internal options which are just pass-through values of buildManifest

Closes vercel#13851
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@timneutkens timneutkens

Labels
None yet
Projects
None yet
Milestone
june 2020
Development

Successfully merging a pull request may close this issue.

Clean up render.tsx options timneutkens/next.js
3 participants
@Timer @timneutkens @balazsorban44