Clean up AMP bundle removal #14130

timneutkens · 2020-06-12T15:11:55Z

Drops the entrypoint instead of removing the underlying file.

vercel · 2020-06-12T15:12:00Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click on the icon next to each commit.

…did-hash

ijjk · 2020-06-13T11:35:46Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
buildDuration	11.3s	11.4s	⚠️ +125ms
nodeModulesSize	65.2 MB	65.2 MB	⚠️ +3.08 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.841	1.888	⚠️ +0.05
/ avg req/sec	1358.13	1324.41	-33.72
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.063	1.13	⚠️ +0.07
/error-in-render avg req/sec	2352.86	2212.6	-140.26

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
main-HASH.js gzip	6.51 kB	6.51 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..0538.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.9 kB	56.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
main-HASH.module.js gzip	5.6 kB	5.6 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.4 kB	52.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
_error.js gzip	3.37 kB	3.37 kB	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
hooks.js gzip	881 B	881 B	✓
_app.js gzip	1.26 kB	1.26 kB	✓
Overall change	8.34 kB	8.34 kB	✓

Client Pages Modern

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
index.module.js gzip	223 B	223 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
hooks.module.js gzip	383 B	383 B	✓
_error.module.js gzip	2.21 kB	2.21 kB	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
_app.module.js gzip	604 B	604 B	✓
Overall change	5.49 kB	5.49 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
_buildManifest.js gzip	270 B	270 B	✓
_buildManife..dule.js gzip	274 B	274 B	✓
Overall change	544 B	544 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
index.html gzip	956 B	956 B	✓
link.html gzip	963 B	963 B	✓
withRouter.html gzip	949 B	949 B	✓
Overall change	2.87 kB	2.87 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
buildDuration	11.9s	12.5s	⚠️ +593ms
nodeModulesSize	65.2 MB	65.2 MB	⚠️ +3.08 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
main-HASH.js gzip	6.51 kB	6.51 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..0538.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.9 kB	56.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
main-HASH.module.js gzip	5.6 kB	5.6 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.4 kB	52.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
_error.js gzip	3.37 kB	3.37 kB	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
hooks.js gzip	881 B	881 B	✓
_app.js gzip	1.26 kB	1.26 kB	✓
Overall change	8.34 kB	8.34 kB	✓

Client Pages Modern

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
index.module.js gzip	223 B	223 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
hooks.module.js gzip	383 B	383 B	✓
_error.module.js gzip	2.21 kB	2.21 kB	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
_app.module.js gzip	604 B	604 B	✓
Overall change	5.49 kB	5.49 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
_buildManifest.js gzip	270 B	270 B	✓
_buildManife..dule.js gzip	274 B	274 B	✓
Overall change	544 B	544 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
_error.js	875 kB	875 kB	⚠️ +268 B
404.html	4.17 kB	4.17 kB	✓
hooks.html	3.79 kB	3.79 kB	✓
index.js	875 kB	875 kB	⚠️ +268 B
link.js	913 kB	913 kB	⚠️ +268 B
routerDirect.js	905 kB	906 kB	⚠️ +268 B
withRouter.js	905 kB	906 kB	⚠️ +268 B
Overall change	4.48 MB	4.48 MB	⚠️ +1.34 kB

packages/next/build/webpack/plugins/next-drop-client-page-plugin.ts

ijjk · 2020-06-13T19:32:04Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
buildDuration	11s	10.4s	-656ms
nodeModulesSize	65.2 MB	65.2 MB	⚠️ +4.72 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.932	1.72	-0.21
/ avg req/sec	1293.83	1453.41	⚠️ +159.58
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.149	1.018	-0.13
/error-in-render avg req/sec	2174.88	2454.68	⚠️ +279.8

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
main-HASH.js gzip	6.51 kB	6.51 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..0538.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.9 kB	56.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
main-HASH.module.js gzip	5.6 kB	5.6 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.4 kB	52.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
_error.js gzip	3.37 kB	3.37 kB	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
hooks.js gzip	881 B	881 B	✓
_app.js gzip	1.26 kB	1.26 kB	✓
Overall change	8.34 kB	8.34 kB	✓

Client Pages Modern

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
index.module.js gzip	223 B	223 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
hooks.module.js gzip	383 B	383 B	✓
_error.module.js gzip	2.21 kB	2.21 kB	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
_app.module.js gzip	604 B	604 B	✓
Overall change	5.49 kB	5.49 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
_buildManifest.js gzip	270 B	270 B	✓
_buildManife..dule.js gzip	274 B	274 B	✓
Overall change	544 B	544 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
index.html gzip	956 B	956 B	✓
link.html gzip	963 B	963 B	✓
withRouter.html gzip	949 B	949 B	✓
Overall change	2.87 kB	2.87 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
buildDuration	12.3s	11.3s	-1s
nodeModulesSize	65.2 MB	65.2 MB	⚠️ +4.72 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
main-HASH.js gzip	6.51 kB	6.51 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..0538.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.9 kB	56.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
main-HASH.module.js gzip	5.6 kB	5.6 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.4 kB	52.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
_error.js gzip	3.37 kB	3.37 kB	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
hooks.js gzip	881 B	881 B	✓
_app.js gzip	1.26 kB	1.26 kB	✓
Overall change	8.34 kB	8.34 kB	✓

Client Pages Modern

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
index.module.js gzip	223 B	223 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
hooks.module.js gzip	383 B	383 B	✓
_error.module.js gzip	2.21 kB	2.21 kB	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
_app.module.js gzip	604 B	604 B	✓
Overall change	5.49 kB	5.49 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
_buildManifest.js gzip	270 B	270 B	✓
_buildManife..dule.js gzip	274 B	274 B	✓
Overall change	544 B	544 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
_error.js	875 kB	875 kB	⚠️ +268 B
404.html	4.17 kB	4.17 kB	✓
hooks.html	3.79 kB	3.79 kB	✓
index.js	875 kB	875 kB	⚠️ +268 B
link.js	913 kB	913 kB	⚠️ +268 B
routerDirect.js	905 kB	906 kB	⚠️ +268 B
withRouter.js	905 kB	906 kB	⚠️ +268 B
Overall change	4.48 MB	4.48 MB	⚠️ +1.34 kB

ijjk · 2020-06-14T11:23:24Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
buildDuration	12s	11.7s	-356ms
nodeModulesSize	65.2 MB	65.2 MB	⚠️ +4.49 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.975	1.922	-0.05
/ avg req/sec	1265.97	1300.44	⚠️ +34.47
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.149	1.157	⚠️ +0.01
/error-in-render avg req/sec	2175.9	2159.84	-16.06

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
main-HASH.js gzip	6.51 kB	6.51 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..0538.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.9 kB	56.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
main-HASH.module.js gzip	5.6 kB	5.6 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.4 kB	52.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
_error.js gzip	3.37 kB	3.37 kB	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
hooks.js gzip	881 B	881 B	✓
_app.js gzip	1.26 kB	1.26 kB	✓
Overall change	8.34 kB	8.34 kB	✓

Client Pages Modern

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
index.module.js gzip	223 B	223 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
hooks.module.js gzip	383 B	383 B	✓
_error.module.js gzip	2.21 kB	2.21 kB	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
_app.module.js gzip	604 B	604 B	✓
Overall change	5.49 kB	5.49 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
_buildManifest.js gzip	270 B	270 B	✓
_buildManife..dule.js gzip	274 B	274 B	✓
Overall change	544 B	544 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
index.html gzip	956 B	956 B	✓
link.html gzip	963 B	963 B	✓
withRouter.html gzip	949 B	949 B	✓
Overall change	2.87 kB	2.87 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
buildDuration	12.8s	12.8s	⚠️ +2ms
nodeModulesSize	65.2 MB	65.2 MB	⚠️ +4.49 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
main-HASH.js gzip	6.51 kB	6.51 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..0538.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.9 kB	56.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
main-HASH.module.js gzip	5.6 kB	5.6 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.4 kB	52.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
_error.js gzip	3.37 kB	3.37 kB	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
hooks.js gzip	881 B	881 B	✓
_app.js gzip	1.26 kB	1.26 kB	✓
Overall change	8.34 kB	8.34 kB	✓

Client Pages Modern

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
index.module.js gzip	223 B	223 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
hooks.module.js gzip	383 B	383 B	✓
_error.module.js gzip	2.21 kB	2.21 kB	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
_app.module.js gzip	604 B	604 B	✓
Overall change	5.49 kB	5.49 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
_buildManifest.js gzip	270 B	270 B	✓
_buildManife..dule.js gzip	274 B	274 B	✓
Overall change	544 B	544 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
_error.js	875 kB	875 kB	⚠️ +268 B
404.html	4.17 kB	4.17 kB	✓
hooks.html	3.79 kB	3.79 kB	✓
index.js	875 kB	875 kB	⚠️ +268 B
link.js	913 kB	913 kB	⚠️ +268 B
routerDirect.js	905 kB	906 kB	⚠️ +268 B
withRouter.js	905 kB	906 kB	⚠️ +268 B
Overall change	4.48 MB	4.48 MB	⚠️ +1.34 kB

Timer

Lgtm if tests are passing!

ijjk · 2020-06-14T12:45:22Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
buildDuration	13.3s	12.6s	-761ms
nodeModulesSize	65.2 MB	65.2 MB	⚠️ +4.49 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.256	2.31	⚠️ +0.05
/ avg req/sec	1107.93	1082.31	-25.62
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.523	1.469	-0.05
/error-in-render avg req/sec	1641.3	1701.64	⚠️ +60.34

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
main-HASH.js gzip	6.51 kB	6.51 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..0538.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.9 kB	56.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
main-HASH.module.js gzip	5.6 kB	5.6 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.4 kB	52.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
_error.js gzip	3.37 kB	3.37 kB	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
hooks.js gzip	881 B	881 B	✓
_app.js gzip	1.26 kB	1.26 kB	✓
Overall change	8.34 kB	8.34 kB	✓

Client Pages Modern

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
index.module.js gzip	223 B	223 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
hooks.module.js gzip	383 B	383 B	✓
_error.module.js gzip	2.21 kB	2.21 kB	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
_app.module.js gzip	604 B	604 B	✓
Overall change	5.49 kB	5.49 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
_buildManifest.js gzip	270 B	270 B	✓
_buildManife..dule.js gzip	274 B	274 B	✓
Overall change	544 B	544 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
index.html gzip	956 B	956 B	✓
link.html gzip	963 B	963 B	✓
withRouter.html gzip	949 B	949 B	✓
Overall change	2.87 kB	2.87 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
buildDuration	13.7s	13.5s	-251ms
nodeModulesSize	65.2 MB	65.2 MB	⚠️ +4.49 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
main-HASH.js gzip	6.51 kB	6.51 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..0538.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.9 kB	56.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
main-HASH.module.js gzip	5.6 kB	5.6 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.4 kB	52.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
_error.js gzip	3.37 kB	3.37 kB	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
hooks.js gzip	881 B	881 B	✓
_app.js gzip	1.26 kB	1.26 kB	✓
Overall change	8.34 kB	8.34 kB	✓

Client Pages Modern

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
index.module.js gzip	223 B	223 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
hooks.module.js gzip	383 B	383 B	✓
_error.module.js gzip	2.21 kB	2.21 kB	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
_app.module.js gzip	604 B	604 B	✓
Overall change	5.49 kB	5.49 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
_buildManifest.js gzip	270 B	270 B	✓
_buildManife..dule.js gzip	274 B	274 B	✓
Overall change	544 B	544 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add/remove-buildid-hash	Change
_error.js	875 kB	875 kB	⚠️ +268 B
404.html	4.17 kB	4.17 kB	✓
hooks.html	3.79 kB	3.79 kB	✓
index.js	875 kB	875 kB	⚠️ +268 B
link.js	913 kB	913 kB	⚠️ +268 B
routerDirect.js	905 kB	906 kB	⚠️ +268 B
withRouter.js	905 kB	906 kB	⚠️ +268 B
Overall change	4.48 MB	4.48 MB	⚠️ +1.34 kB

Updates the way filenames are generated for browser compilation. Notably: - All entry bundles now have hashes in production, this includes pages (previously pages used a buildId in the path) - The AmpFiles no longer depends on hardcoded bundle names, it uses the buildManifest instead (internals) - All cases where we match the page name from the chunk/entrypoint name now use the same function `getRouteFromEntrypoint` (internals) - In development we no longer include the "faked" `buildId` set to `development` for page files, instead we just use the `/_next/static/pages` path (was `/_next/static/development/pages`). This was changed as it caused unneeded complexity and makes generating the bundles easier (internals) - Updated tons of tests to be more resilient to these changes by relying on the buildManifest instead of hardcoded paths (internals) Follow up of these PRs: #13759 #13870 #13937 #14130 #14176 #14268 Fixes #6303 Fixes #12087 Fixes #1948 Fixes #4368 Fixes #4255 Fixes #2548

Drops the entrypoint instead of removing the underlying file.

Updates the way filenames are generated for browser compilation. Notably: - All entry bundles now have hashes in production, this includes pages (previously pages used a buildId in the path) - The AmpFiles no longer depends on hardcoded bundle names, it uses the buildManifest instead (internals) - All cases where we match the page name from the chunk/entrypoint name now use the same function `getRouteFromEntrypoint` (internals) - In development we no longer include the "faked" `buildId` set to `development` for page files, instead we just use the `/_next/static/pages` path (was `/_next/static/development/pages`). This was changed as it caused unneeded complexity and makes generating the bundles easier (internals) - Updated tons of tests to be more resilient to these changes by relying on the buildManifest instead of hardcoded paths (internals) Follow up of these PRs: vercel#13759 vercel#13870 vercel#13937 vercel#14130 vercel#14176 vercel#14268 Fixes vercel#6303 Fixes vercel#12087 Fixes vercel#1948 Fixes vercel#4368 Fixes vercel#4255 Fixes vercel#2548

Clean up AMP bundle removal

8ff00f2

timneutkens requested review from ijjk, lfades and Timer as code owners June 12, 2020 15:11

ijjk added the type: next label Jun 12, 2020

timneutkens marked this pull request as draft June 12, 2020 15:12

Add declaration

cc19585

This comment has been minimized.

Sign in to view

Check entryModule

fc41b16

This comment has been minimized.

Sign in to view

timneutkens added 2 commits June 13, 2020 11:58

Merge branch 'canary' of github.com:zeit/next.js into add/remove-buil…

7189776

…did-hash

Update to use seal instead based on recommendation from Tobias

d3780ae

timneutkens marked this pull request as ready for review June 13, 2020 10:08

This comment has been minimized.

Sign in to view

Show AMP in the build output

5a06d06

sokra reviewed Jun 13, 2020

View reviewed changes

packages/next/build/webpack/plugins/next-drop-client-page-plugin.ts Outdated Show resolved Hide resolved

sokra reviewed Jun 13, 2020

View reviewed changes

packages/next/build/webpack/plugins/next-drop-client-page-plugin.ts Outdated Show resolved Hide resolved

timneutkens added 2 commits June 13, 2020 18:18

Use weakmap instead of editing variables

e43622c

Look up entry module through reasons

7c92b69

Update to use snippet Tobias provided

17c489b

Timer approved these changes Jun 14, 2020

View reviewed changes

Merge branch 'canary' into add/remove-buildid-hash

a3ebc6b

kodiakhq bot merged commit 27f653b into vercel:canary Jun 14, 2020

timneutkens deleted the add/remove-buildid-hash branch June 14, 2020 15:30

timneutkens mentioned this pull request Jun 20, 2020

Update filename generation for client-side compilation #14279

Merged

timneutkens mentioned this pull request Jul 4, 2020

feat: Webpack 5 Experimental Support #10885

Closed

9 tasks

rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020

Clean up AMP bundle removal (vercel#14130)

b3b5166

Drops the entrypoint instead of removing the underlying file.

ka2jun8 mentioned this pull request Sep 8, 2020

AMP First Pages: Could not find files for /xxx in .next/build-manifest.json #16926

Closed

vercel locked as resolved and limited conversation to collaborators Jan 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clean up AMP bundle removal #14130

Clean up AMP bundle removal #14130

timneutkens commented Jun 12, 2020 •

edited

Loading

vercel bot commented Jun 12, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ijjk commented Jun 13, 2020

ijjk commented Jun 13, 2020

ijjk commented Jun 14, 2020

Timer left a comment

ijjk commented Jun 14, 2020

Clean up AMP bundle removal #14130

Clean up AMP bundle removal #14130

Conversation

timneutkens commented Jun 12, 2020 • edited Loading

vercel bot commented Jun 12, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ijjk commented Jun 13, 2020

Stats from current PR

ijjk commented Jun 13, 2020

Stats from current PR

ijjk commented Jun 14, 2020

Stats from current PR

Timer left a comment

Choose a reason for hiding this comment

ijjk commented Jun 14, 2020

Stats from current PR

timneutkens commented Jun 12, 2020 •

edited

Loading