-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.vscode folder being added #42213
Comments
Bumping this. Super annoying to see my VS Code settings overwritten. Also, when working in a monorepo, this also makes no sense. I've found a few other issues that have been closed to inactivity, but this is absolutely still an issue @balazsorban44 . Problems:
Relevant issues:
Solution(s): |
in monorepo the .vscode folder is also create in the subproject instead of the root folder. |
+1. Using WebStrom. This folder keeps showing up after every build. |
Just revert #41710 and similar patches until this is figured out? Assuming developers have a single project at the root of their repo can no longer be done -- especially after the Vercel acquisition of Turborepo. Maybe just a If it really is desired to help with these types configuration changes for us, it would be great if it was done in a |
+1 for not automatically creating |
Bumping this again. I'm not using VS Code and I don't want the |
This is a vexing problem for monorepo users...:cry: |
We are not VS Code users, and we have a mono-repo that is not at the root, and it lives next to other projects that aren't even NodeJS |
I don't use VS code and I hate that On a side note, why was the decision of creating/updating |
@vighnesh153 Couldn't agree more. This unreasonable push of vscode is just 🤮 How hard it is to create the file on your own if you need it... |
…ting away from NextJS
Hey all, thanks for the feedback! The Let me see how we can improve this! |
@shuding People can manage this themselves by setting |
@will-stone That's the default behavior of Jetbrains editors which is what I expect. I wish VS Code can have that as a default too but unfortunately that's not the case. I've got people asking "why autocompletion isn't working" because they don't know how to set that up, or it isn't very obvious. |
Could this be a documented thing then? As writing config files to people's projects doesn't sound like it's winning you fans ☝️ |
## What? Removes writing the `.vscode/settings.json` config. This config is needed in order to leverage the new Next.js TypeScript plugin. What we'll do instead is add a message in the docs on how to enable it. We'll also explore a VSCode extension that warns when you don't have the TypeScript plugin set up. ## How? Removed the code related to writing `.vscode`. Closes #42213 <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you. |
Verify canary release
Provide environment information
What browser are you using? (if relevant)
No response
How are you deploying your application? (if relevant)
No response
Describe the Bug
.vscode folder and files being added whenever running the server. I'm not using vscode, so this shouldn't apply, is there a reason this needs to be added?
Expected Behavior
Don't generate a .vscode folder
Link to reproduction
https://codesandbox.io/s/next-vscode-settings-generation-bug-c9ouvj?file=/package.json
To Reproduce
https://github.com/vercel/next.js/pull/42169 removed related issue, the .gitignore was fixed but vscode was not.
The text was updated successfully, but these errors were encountered: