-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running the dev server is overwriting my vscode settings file, and updating my .gitignore #41808
Comments
The same issue here, DON'T override my |
This ensures we correctly preserve comments in the config similar to our tsconfig handling and removes the `gitignore` updating as we can't infer safely if a user wants this file ignored or not. Fixes: #41808 ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have a helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm build && pnpm lint` - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
The .gitignore is not updating anymore, but it seems this didn't fix adding the .vscode folder. Especially for those who don't use vscode, it just adds an unnecessary folder |
This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you. |
Verify canary release
Provide environment information
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 21.6.0: Wed Aug 10 14:28:23 PDT 2022; root:xnu-8020.141.5~2/RELEASE_ARM64_T6000
Binaries:
Node: 16.14.0
npm: 8.3.1
Yarn: 1.22.19
pnpm: 7.13.4
Relevant packages:
next: 12.3.2-canary.43
eslint-config-next: 13.0.0
react: 18.2.0
react-dom: 18.2.0
What browser are you using? (if relevant)
Chrome
How are you deploying your application? (if relevant)
N/A
Describe the Bug
I have a
settings.json
file in my project's.vscode
folder. It has some settings in there that I need for my project. However, runningnext dev
wipes this file and replaces it with some kind of TypeScript settings.Before
After
Also, I want to push this folder to git. Currently my
.gitignore
keeps being updated with a new.vscode
line added to it, which I don't want.This bug appears to exist in both the latest canary release and 13.0.0
Expected Behavior
Don't remove my settings. Add the lines to the existing JSON file instead of overwriting the file. Also, don't force me to ignore the
.vscode
folder if I DO want to add it to git.Link to reproduction
N/A
To Reproduce
.vscode
foldersettings.json
file to that foldernext dev
The text was updated successfully, but these errors were encountered: