-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dabc64b
to
7a3bc36
Compare
I noticed that
The last issue is with I have also subscribed to the issue [feature] support npm workspaces. There may be a better solution in the future. |
I noticed that gts fix and gts link wasn't working in the npm workspaces. This is related to the issues: gts monorepo does not work with npm ? google/gts#752 gts does not work in a yarn workspaces monorepo google/gts#490 The last issue is with yarn but has more discussion. One solution was using nohoist. This is not a default option with npm. So I tried with the following package https://github.com/zgriesinger/noist. But this did not fix the errors. The last solution mentioned was only linting from the root level; this works. I have also subscribed to the issue [feature] support npm workspaces. There may be a better solution in the future.
I have updated the workflows or added the needed scripts to package.json. I cannot see if the workflows are working. The Vercel build first needs to be successful. |
# Conflicts: # package-lock.json # package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or should we make an app-specific file for this, so as to make its scope clear (e.g. end-to-end-testing-dataset-browser.yml
)?
This work is moved to https://github.com/colonial-heritage/colonial-collections |
/components
TODO