Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Add turborepo #192

Closed
wants to merge 30 commits into from
Closed

Add turborepo #192

wants to merge 30 commits into from

Conversation

barbarah
Copy link
Contributor

@barbarah barbarah commented Apr 6, 2023

  • add Turborepo
  • Move the dataset browser to the app workspace
  • Use the three default turbo packages, and update with our config
    • eslint-config-custom
    • tsconfig
    • UI
      • Add the components, now placed under /components

TODO

  • fix the vercel build
  • Check the GitHub workflows
  • update readme
  • What to do with the docs folder?
  • Docker

@vercel
Copy link

vercel bot commented Apr 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dataset-browser ❌ Failed (Inspect) Apr 13, 2023 7:00am

packages/eslint-config-custom/package.json Outdated Show resolved Hide resolved
packages/tailwind-config/package.json Outdated Show resolved Hide resolved
packages/tsconfig/README.md Outdated Show resolved Hide resolved
packages/tsconfig/base.json Show resolved Hide resolved
packages/tsconfig/base.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
packages/tsconfig/base.json Outdated Show resolved Hide resolved
packages/ui/package.json Outdated Show resolved Hide resolved
packages/ui/package.json Outdated Show resolved Hide resolved
@barbarah
Copy link
Contributor Author

I noticed that gts fix and gts link wasn't working in the npm workspaces. This is related to the issues:

The last issue is with yarn but has more discussion. One solution was using nohoist. This is not a default option with npm. So I tried with the following package https://github.com/zgriesinger/noist. But this did not fix the errors. The last solution mentioned was only linting from the root level; this works.

I have also subscribed to the issue [feature] support npm workspaces. There may be a better solution in the future.

I noticed that gts fix and gts link wasn't working in the npm workspaces. This is related to the issues:

gts monorepo does not work with npm ? google/gts#752
gts does not work in a yarn workspaces monorepo google/gts#490
The last issue is with yarn but has more discussion. One solution was using nohoist. This is not a default option with npm. So I tried with the following package https://github.com/zgriesinger/noist. But this did not fix the errors. The last solution mentioned was only linting from the root level; this works.

I have also subscribed to the issue [feature] support npm workspaces. There may be a better solution in the future.
@barbarah
Copy link
Contributor Author

I have updated the workflows or added the needed scripts to package.json. I cannot see if the workflows are working. The Vercel build first needs to be successful.

# Conflicts:
#       package-lock.json
#       package.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or should we make an app-specific file for this, so as to make its scope clear (e.g. end-to-end-testing-dataset-browser.yml)?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
packages/tsconfig/nextjs.json Outdated Show resolved Hide resolved
packages/tsconfig/nextjs.json Outdated Show resolved Hide resolved
packages/tsconfig/nextjs.json Outdated Show resolved Hide resolved
packages/tsconfig/react-library.json Outdated Show resolved Hide resolved
packages/eslint-config-custom/package.json Outdated Show resolved Hide resolved
@barbarah barbarah marked this pull request as ready for review April 13, 2023 08:05
@barbarah
Copy link
Contributor Author

@barbarah barbarah closed this Apr 13, 2023
@barbarah barbarah deleted the 191-add-turborepo branch June 12, 2023 07:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Turborepo and move the dataset browser to a workspace app.
2 participants