Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: recursively replace ExprRef with SignalRef #7445

Draft
wants to merge 3 commits into
base: next
Choose a base branch
from
Draft

refactor: recursively replace ExprRef with SignalRef #7445

wants to merge 3 commits into from

Conversation

domoritz
Copy link
Member

@domoritz domoritz commented May 8, 2021 •
edited
Loading

Together with #7438, this will allow us to have stricter types and also refactor a bunch of code

@domoritz domoritz requested review from kanitw and a team May 8, 2021 01:02
@domoritz
Copy link
Member Author

domoritz commented May 8, 2021

After this, I think we can remove a lot of the signalRef methods in common.ts.

As a follow up, look at these PRs to see what we can revert: #6825, #6826, #6847, #6849, #6850, #6806, and #6805.

@domoritz domoritz mentioned this pull request May 11, 2021
Open
@kanitw kanitw mentioned this pull request Aug 15, 2021
Open
@hydrosquall hydrosquall changed the base branch from master to next March 8, 2022 01:06
@domoritz domoritz marked this pull request as draft December 15, 2023 19:22
@lsh lsh mentioned this pull request Apr 3, 2024
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanitw kanitw Awaiting requested review from kanitw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@domoritz