-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make most types generic on SignalRef or ExprRef #7438
base: next
Are you sure you want to change the base?
Conversation
const mainTitle = withFieldName ? ` of ${getTitle(continuousAxisChannelDef)}` : ''; | ||
return { | ||
field: fieldPrefix + continuousAxisChannelDef.field, | ||
type: continuousAxisChannelDef.type, | ||
title: isSignalRef(titlePrefix) ? {signal: `${titlePrefix}"${escape(mainTitle)}"`} : titlePrefix + mainTitle | ||
// TODO: this was signal: ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems unfinished? Probably need to check for isExprRef.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about this one?
Hi, is this still something that is planned? I'm a Vega beginner, and maybe I'm missing something simple. My data has a numeric value field and a nominal "unit" field. I render a faceted view based on another column called "variable" and use a temporal x axis. I would like to have the chart have a title like " I will try putting together an example in the editor. |
Yes, still planned. I need to pick it up again. |
Thanks @domoritz -- Here is a simple chart in the editor Just so I'm clear, there is no way to have the two y axis labels dynamic: Instead of "value" (the column name). |
No description provided.