Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make most types generic on SignalRef or ExprRef #7438

Draft
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

domoritz
Copy link
Member

@domoritz domoritz commented May 7, 2021

No description provided.

@domoritz domoritz requested review from kanitw and a team May 7, 2021 05:16
@domoritz domoritz changed the title feat: allow signal or expression refs in more places feat: make most types generic on SignalRef or ExprRef May 7, 2021
const mainTitle = withFieldName ? ` of ${getTitle(continuousAxisChannelDef)}` : '';
return {
field: fieldPrefix + continuousAxisChannelDef.field,
type: continuousAxisChannelDef.type,
title: isSignalRef(titlePrefix) ? {signal: `${titlePrefix}"${escape(mainTitle)}"`} : titlePrefix + mainTitle
// TODO: this was signal: ...
Copy link
Member

@kanitw kanitw Oct 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems unfinished? Probably need to check for isExprRef.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this one?

@marr
Copy link

marr commented Oct 20, 2022

Hi, is this still something that is planned? I'm a Vega beginner, and maybe I'm missing something simple. My data has a numeric value field and a nominal "unit" field. I render a faceted view based on another column called "variable" and use a temporal x axis. I would like to have the chart have a title like "variable (unit)" -- the unit is repeated for each row, so I'm not sure how I'd do that.

I will try putting together an example in the editor.

@domoritz
Copy link
Member Author

Yes, still planned. I need to pick it up again.

@marr
Copy link

marr commented Oct 20, 2022

Yes, still planned. I need to pick it up again.

Thanks @domoritz --

Here is a simple chart in the editor

Just so I'm clear, there is no way to have the two y axis labels dynamic:
"Var 1 (psi)"
"Var 2 (psi)"

Instead of "value" (the column name).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Language extensions
Development

Successfully merging this pull request may close these issues.

3 participants