Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise expr/signal code #7459

Open
domoritz opened this issue May 11, 2021 · 1 comment
Open

Revise expr/signal code #7459

domoritz opened this issue May 11, 2021 · 1 comment
Assignees
@domoritz
Labels
RFC / Discussion 💬 For discussing proposed changes
Milestone
5.2

Comments

@domoritz
Copy link
Member

I think we can simplify the code and logic. My proposal is to make spec ad all types only support SignalRefs. Then we use a generic type to replace all SignalRefs with ExprRefs for the types we export. When we compile a spec, we replace all ExprRefs with SignalRefs (#7445).

Do you see any issues with this approach?
@domoritz domoritz self-assigned this May 11, 2021
@domoritz domoritz added the RFC / Discussion 💬 For discussing proposed changes label May 11, 2021
@domoritz domoritz added this to the 5.2 milestone May 11, 2021
@domoritz domoritz mentioned this issue May 14, 2021
Draft
@kanitw
Copy link
Member

kanitw commented Aug 15, 2021

SGTM.

@ijlyttle ijlyttle mentioned this issue Jan 22, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@domoritz domoritz

Labels
RFC / Discussion 💬 For discussing proposed changes
Projects
None yet
Milestone
5.2
Development

No branches or pull requests
2 participants
@kanitw @domoritz