Address crashes caused by lazily bound mac address values #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Address crashes caused by lazily bound mac address values
This fixes #191, #232 and #247 and closes #236. This PR modifies how mac address values are handled at diff evaluation time rather than enforcing a specific format within terraform's state. Rather than using
StateFunc, which has issues with computed fields, this suppresses a plan's diff if the pre and post plan mac address are equal to each other using Go's HardwareAddr type.Test plan:
TestAccXenorchestraVm_createWithSentinelPlanValuefails with the expected error without this fix