Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded throw panic #236

Closed
wants to merge 5 commits into from
Closed

Conversation

ravager-dk
Copy link
Contributor

Fix for issue #232. Remove the panic thrown by having an unknown value from a separate resource. The unformattedMac is instead returned in this case. Validation still prevents using unparseble strings as mac address.

@VirtualDisk
Copy link

Any update on this getting merged?

@ddelnano
Copy link
Collaborator

ddelnano commented May 8, 2023

I would like to understand how this will be accomplished in the new provider framework (as discussed here). I'm hesitant to accept a breaking change without understanding how it will be addressed in the longer term.

I unfortunately haven't had time to do that research myself since I've been traveling a lot the past month.

@ravager-dk
Copy link
Contributor Author

Any updates to this? The new provider framework is not needed at the moment, and awaiting to fix issues until a complete code rewrite is done for the framework seems to me at least unnecessary. With the new Terraform license terms, not even sure we should move beyond current SDK until opentofu becomes standard.
So I still suggest merging this PR.

@ddelnano
Copy link
Collaborator

@ravager-dk sorry for failing to follow up on this. I haven't spent regular time on the provider for a few months, but from this month forward I will be back on a regular schedule.

I'm currently focusing on setting up a CI build, but next week I will circle back to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MAC address of Values Not Yet Known not working
3 participants