Update project to use a valid Go module name (terraform-provider-macaddress
-> github.com/ivoronin/..
)
#3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Update project to use a valid Go module name (
terraform-provider-macaddress
->github.com/ivoronin/terraform-provider-macaddress
)I am the maintainer for the terrform-provider-xenorchestra project and the end users of this project often pair our terraform providers together (VMs sometimes need a parameterized mac address). Unfortunately the xenorchestra provider has a bug where the intermediate state of a
macaddress
resource's output causes a crash (vatesfr/terraform-provider-xenorchestra#191, vatesfr/terraform-provider-xenorchestra#236). In order to address this bug, I wanted to embed this terraform provider into the xenorchestra acceptance test suite to verify the issue was fixed (see vatesfr/terraform-provider-xenorchestra#288).In order to accomplish this, I had to fork your project and change the module name to include a domain prefix to avoid the error seen below:
This change upstreams what I made in my fork to facilitate vatesfr/terraform-provider-xenorchestra#288.
Test plan: Existing acceptance tests pass and changes are consistent with my working fork
Also wanted to say thank you for your work on this project! I pair it with my xenorchestra terraform as well :)