Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Fusion): Spring Boot 2.4 string patterns request mapping compatibility (#12642) (CP: 9.0) #12663

Merged
merged 1 commit into from
Jan 3, 2022
Merged

fix(Fusion): Spring Boot 2.4 string patterns request mapping compatibility (#12642) (CP: 9.0) #12663

merged 1 commit into from
Jan 3, 2022

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

@platosha @vaadin-bot
fix(Fusion): Spring Boot 2.4 string pattern request mapping compatibi…
483d1dc 
…lity (#12642)

Fixes #12623

With Spring Boot 2.6, PathPattern matching is a default, however with
2.4 / 2.5 Spring MVC still uses string-based pattern matching for paths.

This fixes compatibility with string-based pattern mapping mode when
prepending the endpoint path prefix.
@joheriks joheriks added the hilla Issues related to Hilla label Jan 3, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot
Copy link
Collaborator Author

SonarQube analysis reported 1 issue

  1. MAJOR FusionControllerConfiguration.java#L61: Make this anonymous inner class a lambda rule

@github-actions
Copy link

github-actions bot commented Jan 3, 2022 •
edited
Loading

Unit Test Results

   764 files  ±0     764 suites  ±0   25m 20s ⏱️ + 1m 28s
5 690 tests ±0  5 638 ✔️  - 1  52 💤 +1  0 ❌ ±0 
5 726 runs   - 2  5 673 ✔️  - 3  53 💤 +1  0 ❌ ±0 

Results for commit 483d1dc. ± Comparison against base commit ccfde5f.

♻️ This comment has been updated with latest results.

@haijian-vaadin haijian-vaadin enabled auto-merge (squash) January 3, 2022 12:31
@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically.[Message is sent from bot]

@haijian-vaadin haijian-vaadin merged commit 931dbea into 9.0 Jan 3, 2022
@haijian-vaadin haijian-vaadin deleted the cherry-pick-12642-to-9.0-1641210986830 branch January 3, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haijian-vaadin haijian-vaadin haijian-vaadin approved these changes

@vaadin-review-bot vaadin-review-bot vaadin-review-bot approved these changes

Assignees
No one assigned
Labels
hilla Issues related to Hilla +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vaadin-bot @haijian-vaadin @vaadin-review-bot @joheriks @platosha