Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project fails with Spring Boot 2.4.1 #12623

Closed
tarekoraby opened this issue Dec 22, 2021 · 0 comments · Fixed by #12642
Closed

Project fails with Spring Boot 2.4.1 #12623

tarekoraby opened this issue Dec 22, 2021 · 0 comments · Fixed by #12642
Assignees
Labels
hilla Issues related to Hilla

Comments

@tarekoraby
Copy link
Contributor

Description of the bug

The Vaadin Docs project runs fine on Vaadin v22.0.1 + Spring Boot 2.4.1. However, it fails with v22.0.2 + SB 2.4.1 with the error:

An attempt was made to call a method that does not exist. The attempt was made from the following location:

    com.vaadin.fusion.FusionControllerConfiguration.prependEndpointPrefixUrl(FusionControllerConfiguration.java:98)

The following method did not exist:

    'org.springframework.web.servlet.mvc.method.RequestMappingInfo$Builder org.springframework.web.servlet.mvc.method.RequestMappingInfo.mutate()'

v22.0.2 + SB 2.6.1 works fine. Which makes me wonder if the fix for #12474 has actually broken the support for Spring 2.4.1? Or is this something peculiar to the docs project?

Expected behavior

The project should start without an error for the Vaadin v22.0.1 + Spring Boot 2.4.1 combo.

Minimal reproducible example

Run the Vaadin Docs project (default latest branch). Then change the Spring Boot version in the pom.xml to 2.4.1.

Versions

  • Vaadin / Flow version: 22.0.2
  • Java version: 11
  • OS version: Ubuntu
@haijian-vaadin haijian-vaadin added the hilla Issues related to Hilla label Dec 23, 2021
platosha added a commit that referenced this issue Dec 27, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Fixes #12623

With Spring Boot 2.6, PathPattern matching is a default, however with
2.4 / 2.5 Spring MVC still uses string-based pattern matching for paths.

This fixes compatibility with string-based pattern mapping mode when
prepending the endpoint path prefix.
@platosha platosha self-assigned this Dec 27, 2021
platosha added a commit that referenced this issue Dec 27, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Fixes #12623

With Spring Boot 2.6, PathPattern matching is a default, however with
2.4 / 2.5 Spring MVC still uses string-based pattern matching for paths.

This fixes compatibility with string-based pattern mapping mode when
prepending the endpoint path prefix.
platosha added a commit that referenced this issue Dec 28, 2021
…lity

Fixes #12623

With Spring Boot 2.6, PathPattern matching is a default, however with
2.4 / 2.5 Spring MVC still uses string-based pattern matching for paths.

This fixes compatibility with string-based pattern mapping mode when
prepending the endpoint path prefix.
platosha added a commit that referenced this issue Jan 3, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…lity

Fixes #12623

With Spring Boot 2.6, PathPattern matching is a default, however with
2.4 / 2.5 Spring MVC still uses string-based pattern matching for paths.

This fixes compatibility with string-based pattern mapping mode when
prepending the endpoint path prefix.
haijian-vaadin pushed a commit that referenced this issue Jan 3, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…lity (#12642)

Fixes #12623

With Spring Boot 2.6, PathPattern matching is a default, however with
2.4 / 2.5 Spring MVC still uses string-based pattern matching for paths.

This fixes compatibility with string-based pattern mapping mode when
prepending the endpoint path prefix.
vaadin-bot pushed a commit that referenced this issue Jan 3, 2022
…lity (#12642)

Fixes #12623

With Spring Boot 2.6, PathPattern matching is a default, however with
2.4 / 2.5 Spring MVC still uses string-based pattern matching for paths.

This fixes compatibility with string-based pattern mapping mode when
prepending the endpoint path prefix.
haijian-vaadin pushed a commit that referenced this issue Jan 3, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…lity (#12642) (#12663)

Fixes #12623

With Spring Boot 2.6, PathPattern matching is a default, however with
2.4 / 2.5 Spring MVC still uses string-based pattern matching for paths.

This fixes compatibility with string-based pattern mapping mode when
prepending the endpoint path prefix.

Co-authored-by: Anton Platonov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hilla Issues related to Hilla
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants