Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Fusion): Spring Boot 2.4 string patterns request mapping compatibility #12642

Merged
merged 1 commit into from
Jan 3, 2022

Conversation

platosha
Copy link
Contributor

Fixes #12623

With Spring Boot 2.6, PathPattern matching is a default, however with
2.4 / 2.5 Spring MVC still uses string-based pattern matching for paths.

This fixes compatibility with string-based pattern mapping mode when
prepending the endpoint path prefix.

@platosha platosha added the hilla Issues related to Hilla label Dec 27, 2021
@platosha platosha force-pushed the fix/ap/fusion-spring-path-patterns-compat branch from 8760006 to 9782982 Compare December 27, 2021 14:40
@github-actions
Copy link

github-actions bot commented Dec 27, 2021

Unit Test Results

   769 files     769 suites   25m 23s ⏱️
5 735 tests 5 683 ✔️ 52 💤 0
5 768 runs  5 715 ✔️ 53 💤 0

Results for commit 58fa1b6.

♻️ This comment has been updated with latest results.

@platosha platosha force-pushed the fix/ap/fusion-spring-path-patterns-compat branch from 9782982 to 8aaf46e Compare December 28, 2021 10:02
@platosha platosha changed the title fix(Fusion): Spring MVC string patterns request mapping compatibility fix(Fusion): Spring Boot 2.4 string patterns request mapping compatibility Dec 28, 2021
@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 1 issue

  1. MAJOR FusionControllerConfiguration.java#L61: Make this anonymous inner class a lambda rule

haijian-vaadin
haijian-vaadin previously approved these changes Jan 3, 2022
@haijian-vaadin haijian-vaadin enabled auto-merge (squash) January 3, 2022 08:15
…lity

Fixes #12623

With Spring Boot 2.6, PathPattern matching is a default, however with
2.4 / 2.5 Spring MVC still uses string-based pattern matching for paths.

This fixes compatibility with string-based pattern mapping mode when
prepending the endpoint path prefix.
@platosha platosha force-pushed the fix/ap/fusion-spring-path-patterns-compat branch from 8aaf46e to 58fa1b6 Compare January 3, 2022 08:17
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot vaadin-bot added +0.1.0 and removed +0.0.1 labels Jan 3, 2022
@haijian-vaadin haijian-vaadin merged commit 96696f3 into master Jan 3, 2022
@haijian-vaadin haijian-vaadin deleted the fix/ap/fusion-spring-path-patterns-compat branch January 3, 2022 11:54
vaadin-bot pushed a commit that referenced this pull request Jan 3, 2022
…lity (#12642)

Fixes #12623

With Spring Boot 2.6, PathPattern matching is a default, however with
2.4 / 2.5 Spring MVC still uses string-based pattern matching for paths.

This fixes compatibility with string-based pattern mapping mode when
prepending the endpoint path prefix.
haijian-vaadin pushed a commit that referenced this pull request Jan 3, 2022
…lity (#12642) (#12663)

Fixes #12623

With Spring Boot 2.6, PathPattern matching is a default, however with
2.4 / 2.5 Spring MVC still uses string-based pattern matching for paths.

This fixes compatibility with string-based pattern mapping mode when
prepending the endpoint path prefix.

Co-authored-by: Anton Platonov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project fails with Spring Boot 2.4.1
3 participants