-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Fusion): Spring Boot 2.4 string patterns request mapping compatibility #12642
Merged
haijian-vaadin
merged 1 commit into
master
from
fix/ap/fusion-spring-path-patterns-compat
Jan 3, 2022
Merged
fix(Fusion): Spring Boot 2.4 string patterns request mapping compatibility #12642
haijian-vaadin
merged 1 commit into
master
from
fix/ap/fusion-spring-path-patterns-compat
Jan 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8760006
to
9782982
Compare
9782982
to
8aaf46e
Compare
SonarQube analysis reported 1 issue
|
haijian-vaadin
previously approved these changes
Jan 3, 2022
…lity Fixes #12623 With Spring Boot 2.6, PathPattern matching is a default, however with 2.4 / 2.5 Spring MVC still uses string-based pattern matching for paths. This fixes compatibility with string-based pattern mapping mode when prepending the endpoint path prefix.
8aaf46e
to
58fa1b6
Compare
Kudos, SonarCloud Quality Gate passed!
|
haijian-vaadin
approved these changes
Jan 3, 2022
haijian-vaadin
pushed a commit
that referenced
this pull request
Jan 3, 2022
…lity (#12642) (#12663) Fixes #12623 With Spring Boot 2.6, PathPattern matching is a default, however with 2.4 / 2.5 Spring MVC still uses string-based pattern matching for paths. This fixes compatibility with string-based pattern mapping mode when prepending the endpoint path prefix. Co-authored-by: Anton Platonov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12623
With Spring Boot 2.6, PathPattern matching is a default, however with
2.4 / 2.5 Spring MVC still uses string-based pattern matching for paths.
This fixes compatibility with string-based pattern mapping mode when
prepending the endpoint path prefix.