10461 Story: Public Trial Sessions Details Page #5552

Mwindo · 2024-11-14T19:06:32Z

It is probably best to merge 10460 into staging first and then this as soon as we can after.
This way we avoid reviewing duplicate code, and I can address any feedback on 10460 and incorporate it into my PR if need be. Done!

Ticket here. Related ticket is the public Trial Sessions page (10460), with the PR here.

This PR implements the public Trial Sessions Details page. It also adds sealed icons to cases listed in the internal Trial Sessions Details page.

Notes:

Note that @zachrog was a contributor as well, so he should be credited in the release! (Commits attributed to him were lost due to me cherry-picking from another branch.)
See inline comments.

…b for the frontend

… the file anyway

… existing gotoTrialSessionDetailSequence

… TrialSessionDetailHeader to avoid using cerebral

…ivs and classes

… if need be

…tioner and respondent counsel information to show

…et counsels displayed

…he internal trial sessions process; add isSealed to CalendaredCase; the NonMobile UI is essentially functional

…how Sealed for public case title if sealed

…he rename now triggers 'new' type errors in our CI check for old, renamed files

…ch is better

Mwindo · 2024-11-14T19:28:52Z

web-client/integration-tests/dismissNOTTReminder.test.ts

@@ -165,7 +165,7 @@ describe('Dismiss NOTT reminder on calendared trial session within 30-35 day ran
      await cerebralTest.runSequence('dismissThirtyDayTrialAlertSequence');

      expect(cerebralTest.getState('currentPage')).toEqual(
-        'TrialSessionDetail',
+        'TrialSessionDetails',


Some places had Detail (singular), others had Details (plural). I made them all Details.

Mwindo · 2024-11-14T19:29:49Z

...client/src/presenter/actions/Public/TrialSessions/getPublicTrialSessionDetailsAction.test.ts

+    const { output } = await runAction<
+      { trialSession: PublicTrialSessionDetails },
+      PublicClientState
+      // @ts-ignore


Typing for this was a bear. I decided it wasn't worth it. If anyone knows of an easy fix, I'm happy to implement. My workaround fixed the type error but just ended up making the codebase slightly worse.

Mwindo · 2024-11-14T19:32:28Z

web-client/src/presenter/actions/Public/TrialSessions/getPublicTrialSessionDetailsAction.ts

+import { ClientPublicApplicationContext } from '@web-client/applicationContextPublic';
+import { PublicTrialSessionDetails } from '@web-api/business/useCases/trialSessions/getPublicTrialSessionDetailsInteractor';
+
+export const getPublicTrialSessionDetailsAction = async ({


If you compare with getTrialSessionDetailsAction.ts, you'll notice that we are making one less persistence call here. This is because the interactor for getTrialSessionDetailsAction.ts does not get swing session details, so the action has to make a separate call for them. For public trial session details, I put that swing session fetching logic on the interactor itself.

Mwindo · 2024-11-14T19:32:55Z

web-client/src/presenter/actions/Public/generatePublicDocketRecordPdfUrlAction.test.ts

@@ -1,3 +1,4 @@
+import { PublicClientState } from '@web-client/presenter/state-public';


Here and below, I'm just fixing some type errors among the public tests.

Mwindo · 2024-11-14T19:35:59Z

web-client/src/ustc-ui/Icon/CaseIcons.tsx

@@ -0,0 +1,42 @@
+import { ConsolidatedCaseIcon } from '@web-client/ustc-ui/Icon/ConsolidatedCaseIcon';


Rather than have this icon code duplicated in several spots across the trial session details pages, I pulled it out here. Like sorting, I have seen us handle case/docket icons in different ways, and I hope this is a step towards avoiding these distinctions without difference.

Mwindo · 2024-11-14T19:36:05Z

web-client/src/ustc-ui/Icon/CaseIcons.tsx

+  return (
+    <div
+      className="multi-filing-type-icon"
+      style={{ display: 'flex', flexWrap: 'nowrap', gap: '1rem' }} // USWDS overwrites these styles at certain breakpoints even with !important


I don't know how else to get around this USWDS style issue.

Mwindo · 2024-11-14T19:36:46Z

web-client/src/ustc-ui/Icon/CaseIcons.tsx

+    >
+      <span
+        className={
+          formattedCase.isSealed ? 'visibility-visible' : 'visibility-hidden'


I keep the icon present but hidden/inaccessible so that spacing is always consistent.

Mwindo · 2024-11-14T19:37:14Z

web-client/src/ustc-ui/Icon/ConsolidatedCaseIcon.tsx

@@ -20,7 +20,9 @@ export const ConsolidatedCaseIcon = ({
            icon="copy"
          />
          {showLeadCaseIcon && (
-            <span className="fa-inverse lead-case-icon-text">L</span>
+            <span aria-hidden={true} className="fa-inverse lead-case-icon-text">


Updating aria-hidden so that screen readers don't say "L."

Good catch!

Mwindo · 2024-11-14T19:37:36Z

web-client/src/views/AppComponentPublic.tsx

@@ -41,10 +45,12 @@ export const AppComponentPublic = connect(
    currentPage: state.currentPage,
  },
  function AppComponentPublic({ currentPage }) {
-    const focusMain = e => {
-      e && e.preventDefault();
+    const focusMain = (e?: React.MouseEvent) => {


Fixing some type errors

Mwindo · 2024-11-14T19:38:01Z

web-client/src/views/Messages/MessageTable.tsx

-                />
-              );
-            })}
+            <tbody>


Pulling tbody outside of the map. Thanks to Jim L. for catching this.

Mwindo · 2024-11-14T19:38:46Z

web-client/src/views/Practitioners/PractitionerCaseIcons.tsx

@@ -2,6 +2,7 @@ import { Icon } from '@web-client/ustc-ui/Icon/Icon';
 import React from 'react';

 // This might be useful for more than just practitioners
+// It is similar to CaseIcons, but without indentation


Potential refactor fodder.

Mwindo · 2024-11-14T19:39:45Z

web-client/src/views/Public/TrialSessions/PublicTrialSessionsTable.tsx

+        {publicTrialSessionsHelper.trialSessionsCount}
+      </div>
+      <div className="padding-1"></div>
+      <div className="overflow-x-auto">


Added scroll as needed

Mwindo · 2024-11-14T19:40:41Z

web-client/src/views/TrialSessionDetails/AllCases.tsx

+        <div className="text-right">
+          <span className="text-semibold">Count: </span>
+          {allCases.length}
+        </div>
+        <div className="padding-1"></div>
+        <div className="overflow-x-auto overflow-y-hidden">


I updated all of these similar files to style and position the Count indicator in the same way, and added scrolling as needed. This required wrapping much of the component in a div, which registers a deceptively large git diff. The only other changes are using the new "Icons for consolidated and/or sealed cases" text for aria-label.

Mwindo · 2024-11-14T19:42:56Z

web-client/src/views/TrialSessionDetails/TrialSessionDetails.tsx

@@ -75,6 +77,7 @@ export const TrialSessionDetail = connect(
          <TrialSessionInformation />

          {!formattedTrialSessionDetails.isCalendared && (
+            /* @ts-ignore: Tabs needs to be refactored to avoid type errors */


Renaming file caused these type errors to register as "new" and thus fail the CI Typescript checks.

Mwindo · 2024-11-15T14:15:52Z

shared/src/business/entities/cases/Case.sortByDocketNumber.test.ts

@@ -65,3 +65,111 @@ describe('sortByDocketNumber', () => {
    ]);
  });
 });
+
+describe('sortByDocketNumberAndGroupConsolidatedCases', () => {
+  it('should return the cases sorted properly, with a consolidated case appearing after its lead cases', () => {


cases -> case, which I will correct either in a commit addressing other feedback or else in a follow-up PR.

Mwindo · 2024-11-15T14:17:51Z

shared/src/business/entities/cases/Case.sortByDocketNumber.test.ts

+    ]);
+  });
+
+  it('should return the cases sorted properly, when cases contains a consolidated grouping and the lead case is missing', () => {


The next two tests come almost directly from shared/src/business/utilities/trialSession/getFormattedTrialSessionDetails.compareCasesByDocketNumber.test.ts, which test the function that my new sort function is meant to replicate and eventually replace. (I made one small change to put the two member cases out of order in the second test, which makes the test slightly more robust.)

jimlerza · 2024-11-15T18:27:54Z

cypress/local-only/tests/accessibility/public/trialSessions/trial-session-details.cy.ts

+  });
+
+  it('should be free of a11y issues', () => {
+    cy.visit('/trial-session-detail/959c4338-0fac-42eb-b0eb-d53b8d0195cc');


Does this trial session id come from seed data? Is this allowed for local-only tests?

It does come from the seed data, and yes. (It is basically just a copy of this:

ef-cms/cypress/local-only/tests/accessibility/trialSession/judge.cy.ts

Lines 17 to 25 in b687cd5

describe('Trial session details', () => {

it('should be free of a11y issues', () => {

loginAsColvin();

cy.visit('/trial-session-detail/959c4338-0fac-42eb-b0eb-d53b8d0195cc');

cy.contains('Session Information').should('exist');

checkA11y();

});

});

But come to think of it, we probably don't need to use it. I can update this in the follow-up PR.

jimlerza · 2024-11-15T18:38:43Z

web-api/src/business/useCases/trialSessions/getPublicTrialSessionDetailsInteractor.ts

+      // No need to see docket entries
+      const caseWithEmptyDocketEntries = {
+        ...aCase,
+        docketEntries: [],
+      };


Excellent idea!

Thanks to @ttlenard for catching it!

jimlerza · 2024-11-15T18:49:41Z

web-client/src/ustc-ui/Icon/ConsolidatedCaseIcon.tsx

@@ -20,7 +20,9 @@ export const ConsolidatedCaseIcon = ({
            icon="copy"
          />
          {showLeadCaseIcon && (
-            <span className="fa-inverse lead-case-icon-text">L</span>
+            <span aria-hidden={true} className="fa-inverse lead-case-icon-text">


Good catch!

jimlerza · 2024-11-15T18:50:33Z

web-client/src/views/Messages/MessageTable.tsx

-                />
-              );
-            })}
+            <tbody>


Mwindo and others added 30 commits November 4, 2024 12:52

10461-story: get most of the backend stuff working, with a broken stu…

03473e9

…b for the frontend

10461-story: fix type errors in AppComponentPublic since I'm touching…

15ff2c7

… the file anyway

10461-story: get swing session information for a trial; fix typing of…

b6baf10

… existing gotoTrialSessionDetailSequence

10461-story: get PublicTrialSessionDetail.tsx displayed, and refactor…

c7ac13c

… TrialSessionDetailHeader to avoid using cerebral

10461: WIP add session details

f7303b5

10461-story: refactor PublicTrialSessionDetail to avoid unnecessary d…

2703eef

…ivs and classes

10461-story: conditionally render details card

cfb61ab

10461-story: add back to trial sessions button

0accaf8

10461-story: commit todo so other devs can pick up ticket more easily…

f9784fe

… if need be

10461-story: WIP Getting the nonmobile table working; still need peti…

a2dc4e6

…tioner and respondent counsel information to show

10461-story: WIP getting the current as of timestamp, and trying to g…

eecd18f

…et counsels displayed

10461-story: WIP Use same logic for fetching calendared cases as in t…

50fdd93

…he internal trial sessions process; add isSealed to CalendaredCase; the NonMobile UI is essentially functional

10461-story: fix case link in public view, update todo

723789c

10461-story: WIP getting mobile to display

9ff8b20

10461: Rename to public

c3be5d9

10461: Add contact information for public case

3fba0a2

10461: Update types

fc121e0

10461-story: fix merge errors

24abc89

10461-story: beginning some test stuff

435152e

10461: Switch to docker compose

0ffcfb4

10461-story: get sealed case icon appearing for internal users, and s…

44bdc06

…how Sealed for public case title if sealed

10461-story: show only open calendared cases

3277be9

10461-story: fix some type errors

4604558

10461-story: be consistent with sessiondetails vs sessiondetail

866b7e6

10461-story: fix some renaming oversights, and fix some types since t…

2bf8bd0

…he rename now triggers 'new' type errors in our CI check for old, renamed files

10461-story: fix a few failing tests

ec390e0

10461-story: fix another failing test

a001e4e

10461-story: add runPublicAction to avoid some type errors; fix a test

0ae8c2b

10461-story: fix public action unit tests, using John's solutionm whi…

814600c

…ch is better

10461-story: missed a public action test in previous commit

0f65d83

Mwindo commented Nov 14, 2024

View reviewed changes

Mwindo marked this pull request as ready for review November 14, 2024 20:49

Mwindo marked this pull request as draft November 14, 2024 20:50

10461-story: fix edge case in sorting function

6276f61

Mwindo commented Nov 15, 2024

View reviewed changes

Mwindo and others added 2 commits November 15, 2024 13:13

10461-story: merge staging

e3eec01

Merge branch 'staging' into 10461-story-with-10460-merged

8015399

Mwindo marked this pull request as ready for review November 15, 2024 18:16

Mwindo added the Review Please label Nov 15, 2024

jimlerza approved these changes Nov 15, 2024

View reviewed changes

JayFlexy approved these changes Nov 15, 2024

View reviewed changes

cruzjone-flexion approved these changes Nov 15, 2024

View reviewed changes

Mwindo removed the Review Please label Nov 15, 2024

jimlerza merged commit eeb264b into ustaxcourt:staging Nov 15, 2024
44 checks passed

jimlerza deleted the 10461-story-with-10460-merged branch November 15, 2024 21:41

jimlerza mentioned this pull request Nov 15, 2024

Merge staging into prod #5559

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

10461 Story: Public Trial Sessions Details Page #5552

10461 Story: Public Trial Sessions Details Page #5552

Mwindo commented Nov 14, 2024 •

edited

Loading

Mwindo Nov 14, 2024

Mwindo Nov 14, 2024 •

edited

Loading

Mwindo Nov 14, 2024 •

edited

Loading

Mwindo Nov 14, 2024 •

edited

Loading

Mwindo Nov 14, 2024 •

edited

Loading

Mwindo Nov 14, 2024 •

edited

Loading

Mwindo Nov 14, 2024

Mwindo Nov 14, 2024

jimlerza Nov 15, 2024

Mwindo Nov 14, 2024

Mwindo Nov 14, 2024 •

edited

Loading

jimlerza Nov 15, 2024

Mwindo Nov 14, 2024

Mwindo Nov 14, 2024

Mwindo Nov 14, 2024 •

edited

Loading

Mwindo Nov 14, 2024

Mwindo Nov 15, 2024 •

edited

Loading

Mwindo Nov 15, 2024 •

edited

Loading

jimlerza Nov 15, 2024

Mwindo Nov 15, 2024 •

edited

Loading

jimlerza Nov 15, 2024

Mwindo Nov 15, 2024

jimlerza Nov 15, 2024

jimlerza Nov 15, 2024

		@@ -1,3 +1,4 @@
		import { PublicClientState } from '@web-client/presenter/state-public';

		@@ -0,0 +1,42 @@
		import { ConsolidatedCaseIcon } from '@web-client/ustc-ui/Icon/ConsolidatedCaseIcon';

	describe('Trial session details', () => {
	it('should be free of a11y issues', () => {
	loginAsColvin();
	cy.visit('/trial-session-detail/959c4338-0fac-42eb-b0eb-d53b8d0195cc');
	cy.contains('Session Information').should('exist');

	checkA11y();
	});
	});

10461 Story: Public Trial Sessions Details Page #5552

10461 Story: Public Trial Sessions Details Page #5552

Conversation

Mwindo commented Nov 14, 2024 • edited Loading

Notes:

Choose a reason for hiding this comment

Mwindo Nov 14, 2024 • edited Loading

Choose a reason for hiding this comment

Mwindo Nov 14, 2024 • edited Loading

Choose a reason for hiding this comment

Mwindo Nov 14, 2024 • edited Loading

Choose a reason for hiding this comment

Mwindo Nov 14, 2024 • edited Loading

Choose a reason for hiding this comment

Mwindo Nov 14, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mwindo Nov 14, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mwindo Nov 14, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mwindo Nov 15, 2024 • edited Loading

Choose a reason for hiding this comment

Mwindo Nov 15, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mwindo Nov 15, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mwindo commented Nov 14, 2024 •

edited

Loading

Mwindo Nov 14, 2024 •

edited

Loading

Mwindo Nov 14, 2024 •

edited

Loading

Mwindo Nov 14, 2024 •

edited

Loading

Mwindo Nov 14, 2024 •

edited

Loading

Mwindo Nov 14, 2024 •

edited

Loading

Mwindo Nov 14, 2024 •

edited

Loading

Mwindo Nov 14, 2024 •

edited

Loading

Mwindo Nov 15, 2024 •

edited

Loading

Mwindo Nov 15, 2024 •

edited

Loading

Mwindo Nov 15, 2024 •

edited

Loading