10460 story #5542
Merged
10460 story #5542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
October 22, 2024 12:42
…ime a filter is modified; Added pagination to table;
Mwindo
reviewed
Nov 14, 2024
web-client/src/presenter/actions/TrialSession/setTimeStampAction.test.ts
Show resolved
Hide resolved
Mwindo
reviewed
Nov 14, 2024
Mwindo
reviewed
Nov 14, 2024
web-client/src/presenter/computeds/Public/publicTrialSessionHelper.test.ts
Show resolved
Hide resolved
Mwindo
reviewed
Nov 14, 2024
Mwindo
reviewed
Nov 14, 2024
Mwindo
reviewed
Nov 14, 2024
Mwindo
reviewed
Nov 14, 2024
| }} | ||
| > | ||
| {defaultValue && ( | ||
| <option key={defaultValue.label} value={defaultValue.value}> |
There was a problem hiding this comment.
Minor: Can we ensure label will always be unique?
Mwindo
reviewed
Nov 14, 2024
Mwindo
reviewed
Nov 14, 2024
Mwindo
reviewed
Nov 14, 2024
Mwindo
reviewed
Nov 14, 2024
web-client/src/views/Public/TrialsSessions/PublicTrialSessionsFilters.tsx
Show resolved
Hide resolved
Mwindo
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Great work, @cruzjone-flexion and @nechama-krigsman! Thank you!
I left several minor comments. I'm not sure any of these need to be addressed in the current PR, especially since my plan is to open up a follow-up "clean-up" PR anyway to make sure my work in 10461 is consistent with yours. (E.g., I handled the "current as of" differently, and it's probably better to be consistent.)
Comment on lines
+162
to
+173
| const publicTrialsSessionUpdateFormValueSequence = ( | ||
| ...args: Parameters<typeof updateFormValueSequence> | ||
| ) => { | ||
| if (displayProgressSpinnerSequence) | ||
| displayProgressSpinnerSequence({ timeInSeconds: 0.25 }); | ||
| updateFormValueSequence(...args); | ||
| updateFormValueSequence({ | ||
| key: 'pageNumber', | ||
| root: ROOT, | ||
| value: 0, | ||
| }); | ||
| }; |
There was a problem hiding this comment.
Can this be done in Cerebral?
jimlerza
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flexion#10460