-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
10461 Story: Public Trial Sessions Details Page #5552
Merged
jimlerza
merged 56 commits into
ustaxcourt:staging
from
flexion:10461-story-with-10460-merged
Nov 15, 2024
Merged
Changes from all commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
03473e9
10461-story: get most of the backend stuff working, with a broken stu…
Mwindo 15ff2c7
10461-story: fix type errors in AppComponentPublic since I'm touching…
Mwindo b6baf10
10461-story: get swing session information for a trial; fix typing of…
Mwindo c7ac13c
10461-story: get PublicTrialSessionDetail.tsx displayed, and refactor…
Mwindo f7303b5
10461: WIP add session details
Mwindo 2703eef
10461-story: refactor PublicTrialSessionDetail to avoid unnecessary d…
Mwindo cfb61ab
10461-story: conditionally render details card
Mwindo 0accaf8
10461-story: add back to trial sessions button
Mwindo f9784fe
10461-story: commit todo so other devs can pick up ticket more easily…
Mwindo a2dc4e6
10461-story: WIP Getting the nonmobile table working; still need peti…
Mwindo eecd18f
10461-story: WIP getting the current as of timestamp, and trying to g…
Mwindo 50fdd93
10461-story: WIP Use same logic for fetching calendared cases as in t…
Mwindo 723789c
10461-story: fix case link in public view, update todo
Mwindo 9ff8b20
10461-story: WIP getting mobile to display
Mwindo c3be5d9
10461: Rename to public
3fba0a2
10461: Add contact information for public case
fc121e0
10461: Update types
24abc89
10461-story: fix merge errors
Mwindo 435152e
10461-story: beginning some test stuff
Mwindo 0ffcfb4
10461: Switch to docker compose
44bdc06
10461-story: get sealed case icon appearing for internal users, and s…
Mwindo 3277be9
10461-story: show only open calendared cases
Mwindo 4604558
10461-story: fix some type errors
Mwindo 866b7e6
10461-story: be consistent with sessiondetails vs sessiondetail
Mwindo 2bf8bd0
10461-story: fix some renaming oversights, and fix some types since t…
Mwindo ec390e0
10461-story: fix a few failing tests
Mwindo a001e4e
10461-story: fix another failing test
Mwindo 0ae8c2b
10461-story: add runPublicAction to avoid some type errors; fix a test
Mwindo 814600c
10461-story: fix public action unit tests, using John's solutionm whi…
Mwindo 0f65d83
10461-story: missed a public action test in previous commit
Mwindo a90fe3d
10461-story: tentatively add CaseIcons to EligibleCases.tsx, only use…
Mwindo 807a950
10461-story: trying to get to-test PR green
Mwindo 51cdb99
10461-story: remove console logs and add a test for publicTrialSessio…
Mwindo f14799b
10461-story: add unit test for getPublicTrialSessionDetailsAction
Mwindo a885af5
10461-story: a few small changes to tests
Mwindo 75a3ec7
10461-story: remove isRemote, refactor to avoid using cerebral when n…
Mwindo 560583c
10461-story: add a cypress test
Mwindo c828167
10461-story: add test for getPublicTrialSessionDetailsInteractor
Mwindo 9bec3aa
10461-story: address UX feedback
Mwindo e703f27
10461-story: add scrolling, make count indicators even more closely a…
Mwindo f5e8746
10461-story: use text-right instead of push-right
Mwindo 5e3363e
10461-story: fix icon spacing and count indicator
Mwindo 8f78e2f
10461-story: make all counts use the div spacer instead of margin-bottom
Mwindo 8ea8014
10461-story: put back in flex-column (facepalm) and add some spacing …
Mwindo c28d6b3
10461-story: merge in 10460
Mwindo 6aa0c98
10461-story: get rid of TrialsSessions folder, and add an easier-to-u…
Mwindo edc3a68
10461-story: add tests for new sort function
Mwindo ae61338
10461-story: remove estimated end date
Mwindo 79c16b7
10461-story: fix type errors
Mwindo 825f128
10461-story: fix overlooked test
Mwindo 162e883
10461-story: don't show docket entries
Mwindo 6e3e22d
Merge remote-tracking branch 'ustc/staging' into 10461-story-with-104…
Mwindo 0c28ec8
10461-story: fix lock file
Mwindo 6276f61
10461-story: fix edge case in sorting function
Mwindo e3eec01
10461-story: merge staging
Mwindo 8015399
Merge branch 'staging' into 10461-story-with-10460-merged
Mwindo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
14 changes: 14 additions & 0 deletions
14
cypress/local-only/tests/accessibility/public/trialSessions/trial-session-details.cy.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
import { checkA11y } from '../../../../support/generalCommands/checkA11y'; | ||
|
||
describe('Trial Session Details - Public Accessibility', () => { | ||
beforeEach(() => { | ||
Cypress.session.clearCurrentSessionData(); | ||
}); | ||
|
||
it('should be free of a11y issues', () => { | ||
cy.visit('/trial-session-detail/959c4338-0fac-42eb-b0eb-d53b8d0195cc'); | ||
cy.get('[data-testid="public-open-cases"]').click(); | ||
|
||
checkA11y(); | ||
}); | ||
}); |
4 changes: 2 additions & 2 deletions
4
cypress/local-only/tests/integration/trialSession/edit-a-trial-session.cy.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 changes: 56 additions & 0 deletions
56
cypress/local-only/tests/integration/trialSession/public-trial-session-details.cy.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
import { SESSION_TYPES } from '../../../../../shared/src/business/entities/EntityConstants'; | ||
import { createTrialSession } from '../../../../helpers/trialSession/create-trial-session'; | ||
import { goToCase } from '../../../../helpers/caseDetail/go-to-case'; | ||
import { | ||
loginAsDocketClerk, | ||
loginAsPetitioner, | ||
} from '../../../../helpers/authentication/login-as-helpers'; | ||
import { navigateToDashboard } from '../../../support/pages/maintenance'; | ||
import { petitionerCreatesElectronicCaseWithSpouse } from '../../../../helpers/fileAPetition/petitioner-creates-electronic-case'; | ||
import { petitionsClerkServesPetition } from '../../../../helpers/documentQC/petitionsclerk-serves-petition'; | ||
|
||
describe('Public Trial Session Details', () => { | ||
const publicUrlPort = '5678'; | ||
|
||
it('should show trial session details', () => { | ||
navigateToDashboard(); | ||
loginAsPetitioner(); | ||
petitionerCreatesElectronicCaseWithSpouse().then(docketNumber => { | ||
petitionsClerkServesPetition(docketNumber); | ||
loginAsDocketClerk(); | ||
createTrialSession({ sessionType: SESSION_TYPES.motionHearing }).then( | ||
({ trialSessionId }) => { | ||
goToCase(docketNumber); | ||
// Add the case to the trial session, and seal it | ||
cy.get('[data-testid="tab-case-information"]').click(); | ||
cy.get('#add-to-trial-session-btn').click(); | ||
cy.get('label[for="show-all-locations-true"]').click(); | ||
cy.get('select#trial-session').select(trialSessionId); | ||
cy.get('select#trial-session').should('have.value', trialSessionId); | ||
cy.get('#modal-root .modal-button-confirm').click(); | ||
cy.get('.usa-alert--success').should('exist'); | ||
cy.get('[data-testid="seal-case-button"]').click(); | ||
cy.get('[data-testid="modal-button-confirm"]').click(); | ||
cy.get('.usa-alert--success').contains('Case sealed'); | ||
|
||
// Visit the trial session details as a public user and check that expected information is rendered | ||
cy.visit( | ||
`http://localhost:${publicUrlPort}/trial-session-detail/${trialSessionId}`, | ||
); | ||
cy.get('[data-testid="public-trial-session-details-box"]').should( | ||
'exist', | ||
); | ||
cy.contains( | ||
/Information on this page is current as of \d{2}\/\d{2}\/\d{2} ([1-9]|1[0-2]):\d{2} (am|pm) Eastern\./, | ||
).should('exist'); | ||
cy.contains('Count: 1'); | ||
cy.get( | ||
`[data-testid="trial-session-detail-row-${docketNumber}"]`, | ||
).should('exist'); | ||
cy.get('[data-testid="case-sealed-icon"]').should('exist'); | ||
cy.get('[data-testid="case-link"]').contains(docketNumber); | ||
}, | ||
); | ||
}); | ||
}); | ||
}); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this trial session id come from seed data? Is this allowed for
local-only
tests?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does come from the seed data, and yes. (It is basically just a copy of this:
ef-cms/cypress/local-only/tests/accessibility/trialSession/judge.cy.ts
Lines 17 to 25 in b687cd5