Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vote-2643: Update to Vietnamese strings #1095

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Vote-2643: Update to Vietnamese strings #1095

merged 3 commits into from
Nov 14, 2024

Conversation

clmedders
Copy link
Contributor

@clmedders clmedders commented Nov 5, 2024 •
edited
Loading

Jira ticket

Vote-2645

Description

Update to Vietnamese hardcoded string.

Deployment and testing

Post-deploy steps

n/a

QA/Testing instructions

  1. review comment in ticket to check the strings that are still hard coded have been updated

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@rayestrada
Copy link
Contributor

Let's handle all string translations updates in the CMS instead.

@SamiraMSadat SamiraMSadat merged commit 0003f94 into dev Nov 14, 2024
2 checks passed
@rayestrada rayestrada deleted the feature/vote-2643-vi-updates branch December 3, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamiraMSadat SamiraMSadat SamiraMSadat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clmedders @rayestrada @SamiraMSadat