-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mirror Quantum Volume Circuits #1838
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1838 +/- ##
========================================
Coverage 98.54% 98.54%
========================================
Files 73 76 +3
Lines 3357 3510 +153
========================================
+ Hits 3308 3459 +151
- Misses 49 51 +2
|
@nathanshammah This is ready for review. I pretty much re-used some of the code & tests for quantum volume. I am not sure why codecov is failing. The stuff I added seems to be covered. There are 3 unrelated files that seem to show up in the report. Same as the issue in #1841 |
I think I figured out the issue with The files it flagged are the ones that had codecov failing on them previously. I think it is related to this previous PR. This codecov issue was discussed in the other PR as well. But when I merged b14c56c, the codecov path failure issue did not occur after I re-ran the tests. The first time it failed with the same error of indirect changes. |
@nathanshammah this is ready for a review. The test that is failing in unrelated to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @purva-thakre!
Apart from a minor suggestion and fixing a couple typos, this looks ready to go.
Co-authored-by: Misty Wahl <[email protected]>
@nathanshammah did you want to take a look before we merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @purva-thakre !
Co-authored-by: Andrea Mari <[email protected]>
Fixes #1788
List of tests to add: