Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror Quantum Volume Circuits #1838

Merged
merged 14 commits into from
Jun 8, 2023
Merged

Mirror Quantum Volume Circuits #1838

merged 14 commits into from
Jun 8, 2023

Conversation

purva-thakre
Copy link
Collaborator

@purva-thakre purva-thakre commented May 19, 2023

Fixes #1788

List of tests to add:

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch unitaryfund/mitiq/mirror_qv

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #1838 (838e5e6) into master (0716714) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           master    #1838    +/-   ##
========================================
  Coverage   98.54%   98.54%            
========================================
  Files          73       76     +3     
  Lines        3357     3510   +153     
========================================
+ Hits         3308     3459   +151     
- Misses         49       51     +2     
Impacted Files Coverage Δ
mitiq/benchmarks/quantum_volume_circuits.py 100.00% <ø> (ø)
mitiq/benchmarks/mirror_qv_circuits.py 100.00% <100.00%> (ø)

... and 13 files with indirect coverage changes

@purva-thakre purva-thakre marked this pull request as ready for review May 21, 2023 03:54
@purva-thakre
Copy link
Collaborator Author

purva-thakre commented May 21, 2023

@nathanshammah This is ready for review. I pretty much re-used some of the code & tests for quantum volume.

I am not sure why codecov is failing. The stuff I added seems to be covered. There are 3 unrelated files that seem to show up in the report. Same as the issue in #1841

@purva-thakre
Copy link
Collaborator Author

purva-thakre commented May 22, 2023

I think I figured out the issue with codecov based on what I read here.

The files it flagged are the ones that had codecov failing on them previously. I think it is related to this previous PR. This codecov issue was discussed in the other PR as well.

But when I merged b14c56c, the codecov path failure issue did not occur after I re-ran the tests. The first time it failed with the same error of indirect changes.

@purva-thakre purva-thakre self-assigned this May 30, 2023
@purva-thakre
Copy link
Collaborator Author

@nathanshammah this is ready for a review. The test that is failing in unrelated to this PR

Copy link
Contributor

@Misty-W Misty-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @purva-thakre!

Apart from a minor suggestion and fixing a couple typos, this looks ready to go.

mitiq/benchmarks/mirror_qv_circuits.py Outdated Show resolved Hide resolved
mitiq/benchmarks/mirror_qv_circuits.py Outdated Show resolved Hide resolved
mitiq/benchmarks/mirror_qv_circuits.py Outdated Show resolved Hide resolved
mitiq/benchmarks/mirror_qv_circuits.py Outdated Show resolved Hide resolved
mitiq/benchmarks/mirror_qv_circuits.py Outdated Show resolved Hide resolved
@Misty-W
Copy link
Contributor

Misty-W commented Jun 3, 2023

@nathanshammah did you want to take a look before we merge?

Copy link
Member

@andreamari andreamari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @purva-thakre !

mitiq/benchmarks/mirror_qv_circuits.py Outdated Show resolved Hide resolved
@purva-thakre purva-thakre merged commit ffa39ea into master Jun 8, 2023
@purva-thakre purva-thakre deleted the mirror_qv branch June 8, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add mirror quantum volume circuits to benchmarks
3 participants