Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mypy to style guidelines #1841

Merged
merged 2 commits into from
May 22, 2023
Merged

Add mypy to style guidelines #1841

merged 2 commits into from
May 22, 2023

Conversation

purva-thakre
Copy link
Collaborator

Noticed mypy was missing from the style guidelines in docs.

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch unitaryfund/mitiq/mypy_in_doc

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #1841 (b4b1936) into master (0716714) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1841      +/-   ##
==========================================
- Coverage   98.54%   98.44%   -0.10%     
==========================================
  Files          73       73              
  Lines        3357     3400      +43     
==========================================
+ Hits         3308     3347      +39     
- Misses         49       53       +4     

see 3 files with indirect coverage changes

@purva-thakre purva-thakre marked this pull request as ready for review May 19, 2023 21:24
@purva-thakre
Copy link
Collaborator Author

purva-thakre commented May 19, 2023

This is ready. Not sure why codecov is failing.

I did not make any changes to the files that codecov thinks are not covered by tests.

@purva-thakre purva-thakre mentioned this pull request May 21, 2023
5 tasks
Copy link
Member

@natestemen natestemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thinking adding this. Always good to have our processes documented thoroughly.

@purva-thakre purva-thakre merged commit b14c56c into master May 22, 2023
@purva-thakre purva-thakre deleted the mypy_in_doc branch May 22, 2023 21:15
nathanshammah pushed a commit to nathanshammah/mitiq that referenced this pull request May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants