V8: Accessibility Changes For umbEditorHeader Directive (settings section)

[RachBreeze]

This PR extends #6315 adding the screen reader properties and setting the page title for almost all of the remaining menu items in the settings section. It leaves the language and the log viewer as the remaining items to update within this section

[poornimanayar]

Hi @RachBreeze ,

Thank you, you know what happens next!

Poornima

[kjac]

@RachBreeze lovely 👍

A few comments from me:

1. Could you please resolve the merge localization conflicts?
2. Is there any reason why you're creating all those vm.header objects on the controllers? Wouldn't it be easier to simply supply the values directly in the editorfor and setpagetitle attributes of umb-editor-header?

[RachBreeze]

Hi @kjac
Yep I can look at the merge conflicts.
I did try and set the properties on umb-editor-header originally but they wouldn't pass through to the header controller

[RachBreeze]

Hi @kjac
Thank you once again for reviewing.
I've merged the language files, if you have a sec it would be good to know how I can set VS to keep the formatting the same as those in the xml files, even when I copy and paste the indentation I can't keep it the same :-(

[kjac]

@RachBreeze this works as advertised 👏 happy to approve it!

For future reference you can pass the values directly to the header directive like this:

<umb-editor-header
	name="vm.relationType.name"
	alias="vm.relationType.alias"
	hide-description="true"
	hide-icon="true"
	navigation="vm.page.navigation"
	editorfor="'relationType_tabRelationType'"
	setpagetitle="true">
</umb-editor-header>

...notice the single quotes around editorfor.

[kjac]

As for the language files, well... that's a longer story.

At some point in the past someone formatted one or more of them in a manner that doesn't conform to the default indentation which 4 spaces, as defined in .editorconfig:

# Default settings:
# A newline ending every file
# Use 4 spaces as indentation
[*]
insert_final_newline = true
end_of_line = crlf
indent_style = space
indent_size = 4

As a result, VS fails miserably at indenting these files.

What I usually do is hit Ctrl+Z immediately after copying and pasting an entry in the language files if the indentation looks wrong. VS will usually undo it's failed auto-formatting then, leaving behind something that at least looks correct (even if it is wrong according to .editorconfig).

Logic would dictate that we should simply force format those files in a separate commit to v8/dev and be done with it. Unfortunately this would leave a whole lot of existing PRs with a merge conflict 😞

[kjac]

Merged. Thanks again, @RachBreeze 👍