Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8: Accessibility Changes For umbEditorHeader Directive (settings section) #6986

Merged
merged 5 commits into from
Dec 18, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,8 @@ Use this directive to construct a header inside the main editor window.
if (editorState.current) {
//to do make work for user create/edit
// to do make it work for user group create/ edit
// to make it work for language edit/create
// to do make it work for language edit/create
// to do make it work for log viewer
scope.isNew = editorState.current.id === 0 ||
editorState.current.id === "0" ||
editorState.current.id === -1 ||
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,11 @@ function DataTypeEditController($scope, $routeParams, appState, navigationServic

var evts = [];
var vm = this;


vm.header = {};
vm.header.editorfor = "visuallyHiddenTexts_newDataType";
vm.header.setPageTitle = true;

//setup scope vars
vm.page = {};
vm.page.loading = false;
Expand Down
4 changes: 3 additions & 1 deletion src/Umbraco.Web.UI.Client/src/views/datatypes/edit.html
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@
hide-icon="true"
hide-description="true"
hide-alias="true"
navigation="vm.page.navigation">
navigation="vm.page.navigation"
editorfor="vm.header.editorfor"
setpagetitle="vm.header.setPageTitle">
</umb-editor-header>

<umb-editor-container class="form-horizontal">
Expand Down
3 changes: 2 additions & 1 deletion src/Umbraco.Web.UI.Client/src/views/macros/edit.html
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
alias="vm.macro.alias"
hide-description="true"
hide-icon="true"
navigation="vm.page.navigation">
navigation="vm.page.navigation"editorfor="vm.header.editorfor"
setpagetitle="vm.header.setPageTitle">
</umb-editor-header>

<umb-editor-container class="form-horizontal">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,10 @@ function MacrosEditController($scope, $q, $routeParams, macroResource, editorSta
var vm = this;

vm.promises = {};

vm.header = {};
vm.header.editorfor = "general_macro";
vm.header.setPageTitle = true;

vm.page = {};
vm.page.loading = false;
vm.page.saveButtonState = "init";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ function RelationTypeEditController($scope, $routeParams, relationTypeResource,

var vm = this;

vm.header = {};
vm.header.editorfor = "relationType_tabRelationType";
vm.header.setPageTitle = true;

vm.page = {};
vm.page.loading = false;
vm.page.saveButtonState = "init";
Expand Down
4 changes: 3 additions & 1 deletion src/Umbraco.Web.UI.Client/src/views/relationtypes/edit.html
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@
alias="vm.relationType.alias"
hide-description="true"
hide-icon="true"
navigation="vm.page.navigation">
navigation="vm.page.navigation"
editorfor="vm.header.editorfor"
setpagetitle="vm.header.setPageTitle">
</umb-editor-header>

<umb-editor-container class="form-horizontal">
Expand Down
4,681 changes: 2,341 additions & 2,340 deletions src/Umbraco.Web.UI/Umbraco/config/lang/en.xml

Large diffs are not rendered by default.

4,713 changes: 2,357 additions & 2,356 deletions src/Umbraco.Web.UI/Umbraco/config/lang/en_us.xml

Large diffs are not rendered by default.