Skip to content

Commit

Permalink
V8: Accessibility Changes For umbEditorHeader Directive (settings sec…
Browse files Browse the repository at this point in the history
…tion) (#6986)

* Improved accessibility of the data type edit controller, by implementing the new header directive properties for screen reader only text, and for setting the page title

* Improved accessibility of the macro edit controller, by implementing the new header directive properties for screen reader only text, and for setting the page title

* Improved accessibility of the relation type edit controller, by implementing the new header directive properties for screen reader only text, and for setting the page title

* Added to do note for log viewer
  • Loading branch information
RachBreeze authored and kjac committed Dec 18, 2019
1 parent c6afb86 commit 578a725
Show file tree
Hide file tree
Showing 9 changed files with 4,721 additions and 4,702 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,8 @@ Use this directive to construct a header inside the main editor window.
if (editorState.current) {
//to do make work for user create/edit
// to do make it work for user group create/ edit
// to make it work for language edit/create
// to do make it work for language edit/create
// to do make it work for log viewer
scope.isNew = editorState.current.id === 0 ||
editorState.current.id === "0" ||
editorState.current.id === -1 ||
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,11 @@ function DataTypeEditController($scope, $routeParams, appState, navigationServic

var evts = [];
var vm = this;


vm.header = {};
vm.header.editorfor = "visuallyHiddenTexts_newDataType";
vm.header.setPageTitle = true;

//setup scope vars
vm.page = {};
vm.page.loading = false;
Expand Down
4 changes: 3 additions & 1 deletion src/Umbraco.Web.UI.Client/src/views/datatypes/edit.html
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@
hide-icon="true"
hide-description="true"
hide-alias="true"
navigation="vm.page.navigation">
navigation="vm.page.navigation"
editorfor="vm.header.editorfor"
setpagetitle="vm.header.setPageTitle">
</umb-editor-header>

<umb-editor-container class="form-horizontal">
Expand Down
3 changes: 2 additions & 1 deletion src/Umbraco.Web.UI.Client/src/views/macros/edit.html
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
alias="vm.macro.alias"
hide-description="true"
hide-icon="true"
navigation="vm.page.navigation">
navigation="vm.page.navigation"editorfor="vm.header.editorfor"
setpagetitle="vm.header.setPageTitle">
</umb-editor-header>

<umb-editor-container class="form-horizontal">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,10 @@ function MacrosEditController($scope, $q, $routeParams, macroResource, editorSta
var vm = this;

vm.promises = {};

vm.header = {};
vm.header.editorfor = "general_macro";
vm.header.setPageTitle = true;

vm.page = {};
vm.page.loading = false;
vm.page.saveButtonState = "init";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ function RelationTypeEditController($scope, $routeParams, relationTypeResource,

var vm = this;

vm.header = {};
vm.header.editorfor = "relationType_tabRelationType";
vm.header.setPageTitle = true;

vm.page = {};
vm.page.loading = false;
vm.page.saveButtonState = "init";
Expand Down
4 changes: 3 additions & 1 deletion src/Umbraco.Web.UI.Client/src/views/relationtypes/edit.html
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@
alias="vm.relationType.alias"
hide-description="true"
hide-icon="true"
navigation="vm.page.navigation">
navigation="vm.page.navigation"
editorfor="vm.header.editorfor"
setpagetitle="vm.header.setPageTitle">
</umb-editor-header>

<umb-editor-container class="form-horizontal">
Expand Down
4,681 changes: 2,341 additions & 2,340 deletions src/Umbraco.Web.UI/Umbraco/config/lang/en.xml

Large diffs are not rendered by default.

4,713 changes: 2,357 additions & 2,356 deletions src/Umbraco.Web.UI/Umbraco/config/lang/en_us.xml

Large diffs are not rendered by default.

0 comments on commit 578a725

Please sign in to comment.