Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v8: Fix disappearing image cropper and grid content when using rollback #5792

Merged
merged 5 commits into from
Jun 12, 2020
Merged

v8: Fix disappearing image cropper and grid content when using rollback #5792

merged 5 commits into from
Jun 12, 2020

Conversation

bjarnef
Copy link
Contributor

@bjarnef bjarnef commented Jul 4, 2019 •
edited
Loading

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes #5791

Description

It seems the rollback manipulated to original tab properties in background, which broke the image cropper and grid content. Now it create a copy of the property and old property before using it further in code.

It also shows the loading indicator while fetching a different rollback version.

A few notes to this:

  • It seems the TinyMCE in the grid content sometimes collapse after changing rollback version via dropdown (but not submitting) or an issue when changing tab in the header.
  • When doing a rollback, should the page then refresh or can we show the updated properties? At the moment it shows the current version (not the version roll back to), but the properties are updated after refreshing the page.

@emmaburstow
Copy link
Contributor

Hey @bjarnef

Also, thanks for this one! We'll let you know if we need you,

Em

@bjarnef bjarnef mentioned this pull request Jul 11, 2019
Closed
@bjarnef bjarnef mentioned this pull request Aug 30, 2019
Closed
@PerplexDaniel PerplexDaniel mentioned this pull request May 26, 2020
Closed
@nul800sebastiaan
Merge branch 'v8/contrib' into pr/5792
d133194 
# Conflicts:
#	src/Umbraco.Web.UI.Client/src/views/common/infiniteeditors/rollback/rollback.html
#	src/Umbraco.Web.UI/Umbraco/config/lang/da.xml
#	src/Umbraco.Web.UI/Umbraco/config/lang/en_us.xml
@nul800sebastiaan nul800sebastiaan changed the base branch from v8/dev to v8/contrib June 12, 2020 13:35
@nul800sebastiaan nul800sebastiaan merged commit c4456c5 into umbraco:v8/contrib Jun 12, 2020
@nul800sebastiaan
Copy link
Member

Well, that was almost a year delayed 🙈 but excellent fix @bjarnef - thanks very much! 👍

@nul800sebastiaan nul800sebastiaan mentioned this pull request Jun 12, 2020
Closed
@bjarnef bjarnef deleted the dev-v8-rollback-fixes branch August 2, 2020 10:02
@nul800sebastiaan nul800sebastiaan added release/8.7.0 release/no-notes This is too small to add to the release notes or fixed after a beta/RC labels Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release/no-notes This is too small to add to the release notes or fixed after a beta/RC release/8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v8: Rollback clear image cropper and grid
3 participants
@bjarnef @emmaburstow @nul800sebastiaan