Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback doesn't refresh the editor #6244

Closed
skttl opened this issue Aug 30, 2019 · 5 comments
Closed

Rollback doesn't refresh the editor #6244

skttl opened this issue Aug 30, 2019 · 5 comments

Comments

@skttl
Copy link
Contributor

skttl commented Aug 30, 2019

When rolling back from the history pane in the info tab, the content in the editor stays at the version you rolled back from. You have to reload the page, in order to se the rolled back content. This can be confusing, as I would expect to be able to just rollback, save and publish and have my changes reverted.

But instead, I need to roll back, reload the page, then save and publish.

Reproduction

Open a page and make some changes.
Save those changes.
Roll back to the previous version using the rollback button in the history group in the info pane.
Note that the content is still the newest content. Here I would expect the content to be the content I rolled back to.

Refresh the browser, to see the active content is not the newest anymore (as you would expect it to be).

Both v7 and v8 does this.

@nul800sebastiaan
Copy link
Member

We would welcome you to have a look at this in v8 (we're not creating bigger new features like this for v7 any more).

The tricky part here is surely that we would need to only refresh the editing area and I don't know how to hook into that. However, when we go into infinite editing and update the document type of the current page, we also do a refresh of the editing area so perhaps this could be a similar thing.

@umbrabot
Copy link

Hi @skttl,

We're writing to let you know that we've added the Up For Grabs label to your issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post

Thanks muchly, from your friendly PR team bot :-)

@bjarnef
Copy link
Contributor

bjarnef commented Aug 30, 2019

It seems to be related to this PR I submitted where the image cropper image and grid content disapear on rollback. #5792

@skttl
Copy link
Contributor Author

skttl commented Sep 19, 2019

Just tried this one again on bleeding edge v8/dev and can't reproduce. So something must have fixed it :)

@nul800sebastiaan
Copy link
Member

Ah, I didn't notice it was a duplicate! Yep, fixed yesterday! #6349 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants