Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback - Umbraco 8 #6349

Closed
milance-feelgood opened this issue Sep 16, 2019 · 4 comments · Fixed by #6352
Closed

Rollback - Umbraco 8 #6349

milance-feelgood opened this issue Sep 16, 2019 · 4 comments · Fixed by #6352

Comments

@milance-feelgood
Copy link

Hi everyone,

Rollback function in Umbraco version 8.1.2 doesn't work properly.

Reproduction

When I choose version to which I want to return back current document, content of the page isn't updated with data from selected version - still old content are presented. Even I tried to use "Preview", "Save" or "Save and publish..." buttons, content remains the same like it was before (current-old version).

But, if I choose an version to which I want to rollback and just refresh the page in browser or click on any other node in navigation content tree from the left side, and click back again on current document node, content will be filled-in with correct data from chosen rollback version.

Bug summary

I found the similar issue for an older version of Umbraco:
https://issues.umbraco.org/issue/U4-7261

Specifics

Browser: Version 76.0.3809.132 (Official Build) (64-bit) normal and incognito mode

Steps to reproduce

  • Click on node for which you want to rollback the content
  • Go to "Info" tab
  • Click on "Rollback..." button
  • Choose "Rollback to" which version you want to rollback
  • Click on "Rollback" green button at the bottom-right corner.
  • Go to "Content" tab
  • Take a look on content of the document or
  • Click on "Preview" button.

Expected result

When I choose rollback version of current document and switch to content tab, I expect that content is filled-in with data from chosen version. As confirmation of this, I would see with "Preview" option updated content and don't need to refresh the page or switch to another node and come back to actual one.

Actual result

When I choose rollback version of current document and switch to content tab, content data remains the same (from current - previous version).
In preview I also can see the same (old) version, not from chosen rollback version.

@nul800sebastiaan
Copy link
Member

Thanks @milance-feelgood - yes, this is still the same bug (or.. "missing feature") as U4-7261. It would be great if someone could have a crack at this to try and fix it. I unfortunately don't know if there's a good way for the actions menu to signal to the content editing area to refresh the page though.

@umbrabot
Copy link

Hi @milance-feelgood,

We're writing to let you know that we've added the Up For Grabs label to your issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post

Thanks muchly, from your friendly PR team bot :-)

@stevemegson
Copy link
Contributor

PR #6352 should do the job. It calls reload, loadBreadcrumb and syncTreeNode, I'm not sure whether there's anything else we should be refreshing.

@nul800sebastiaan
Copy link
Member

Fixed in #6352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants