-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v8: Rollback clear image cropper and grid #5791
Comments
Yes, excellent @bjarnef! I was about to make a new issue and PR with essentially the same but thought "let's see if someone else already did this" ;-) This applies to all property editors that have their value stored as JSON, so it's quite a big deal. @nul800sebastiaan Can we please merge the linked PR into v8 soon-ish? Mainly it's about this commit which does an Full commit of @bjarnef with the fix is below (just to show it's tiny): // copy existing properties, so it doesn't manipulate existing properties on page
oldProperty = angular.copy(oldProperty);
property = angular.copy(property); Considering #7950 we would just have to change that to |
Oh, it has been a while since I submitted that PR.. almost forgot about it 🙈 It seems |
Fixed in #5792 |
Ah forgot to update to Utilities.copy - done in 9be4775 |
In Umbraco v8 with latest changes in
v8/dev
branch, when I select rollback and select an older version, but without clicking submit button (rollback), but just close the dialog and go back to the content tab the image cropper and grid no longer shows any values.But when I refresh the page the values image cropper image and grid data are shown.
The text was updated successfully, but these errors were encountered: