Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub issue#11299 fix v8 #11493

Merged
merged 9 commits into from
Oct 29, 2021
Merged

GitHub issue#11299 fix v8 #11493

merged 9 commits into from
Oct 29, 2021

Conversation

IbrahimMNada
Copy link
Contributor

Prerequisites

Issue Description In The Attached Bug :

#11299

Summary : we just need to add a message to tell the User that the Nested Content is not supporting the Tabs in the document types

Fix Steps :

-A new tooltip paragraph is added
image

-When the user chose a zero tabbed Document type it shows the following message :

image

-If there are groups the flow will be normal as always :

image

@umbrabot
Copy link

umbrabot commented Oct 26, 2021

Hi there @uppercuut, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

Copy link
Contributor

@ronaldbarendse ronaldbarendse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @uppercuut, I've reviewed this PR and although it needs some cleaning up, it already looks great!

@mikecp mikecp dismissed ronaldbarendse’s stale review October 29, 2021 16:00

I think all requests from the review have been fulfilled

@mikecp
Copy link
Contributor

mikecp commented Oct 29, 2021

Hi @uppercuut , thanks for this addition, it's always good to give some meaningful feedback to the user 👍

And since it seems to be your first PR to Umbraco, make sure to communicate your "our" profile so that @nul800sebastiaan can grant you our shiny contributor's badge 🥇

Looking forward to your next PR's 😁

@IbrahimMNada
Copy link
Contributor Author

@mikecp
Hello ,
This is my 2nd pr and im so happy about it.
And working with you guys..
If i may ask how to get the contributor badge here on github.
Because thankfully i have it on our Umbraco.

@mikecp
Copy link
Contributor

mikecp commented Oct 29, 2021

Hey @uppercuut ,
I was almost certain I had merged one of your PR's already this week, but I'm following the Candid Contribution hackaton, so I did not make the extra effort to check 😅

Nice, looking forward to the third one then 😁

Regarding the contributor badge on Github, I kind of thought this was automatic, and I don't really know how it can be assigned. Maybe @nul800sebastiaan knows more?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants