-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub issue#11299 fix v8 #11493
GitHub issue#11299 fix v8 #11493
Conversation
Hi there @uppercuut, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @uppercuut, I've reviewed this PR and although it needs some cleaning up, it already looks great!
...braco.Web.UI.Client/src/views/propertyeditors/nestedcontent/nestedcontent.doctypepicker.html
Outdated
Show resolved
Hide resolved
...braco.Web.UI.Client/src/views/propertyeditors/nestedcontent/nestedcontent.doctypepicker.html
Outdated
Show resolved
Hide resolved
I think all requests from the review have been fulfilled
Hi @uppercuut , thanks for this addition, it's always good to give some meaningful feedback to the user 👍 And since it seems to be your first PR to Umbraco, make sure to communicate your "our" profile so that @nul800sebastiaan can grant you our shiny contributor's badge 🥇 Looking forward to your next PR's 😁 |
@mikecp |
Hey @uppercuut , Nice, looking forward to the third one then 😁 Regarding the contributor badge on Github, I kind of thought this was automatic, and I don't really know how it can be assigned. Maybe @nul800sebastiaan knows more? |
Prerequisites
Issue Description In The Attached Bug :
#11299
Summary : we just need to add a message to tell the User that the Nested Content is not supporting the Tabs in the document types
Fix Steps :
-A new tooltip paragraph is added
-When the user chose a zero tabbed Document type it shows the following message :
-If there are groups the flow will be normal as always :