[v9] Nested Content: Cannot pick a Group for an element type with properties in a tab

[BarryFogarty]

Which exact Umbraco version are you using? For example: 8.13.1 - don't just write v8

v9.0.0

Bug summary

When setting up a Nested Content datatype, tabs do not appear in the Group dropdown in the Element Types config. Therefore, you are unable to add an Element Type to a NC datatype with properties only a tab, not a group.

Perhaps this is by design, but it adds confusion when it is possible to set up tabs for Element Types, and create properties in there, without using groups.

Specifics

Either element types should enforce the use of a group (or disallow tabs), or the Group dropdown in the NC config should list Tabs as well as Groups (preferred, but could get confusing with hierarchical structures? - maybe they would have to be flattened to Tab/Group pairs?)

Steps to reproduce

• Create an Element type with a tab ('Content')
• Create a datatype of type Nested Content and pick the above element type in the configuration

Expected result / actual result

Expected result: The Group dropdown to contain the 'Content' tab

Actual result: The Group dropdown contains no values

[ronaldbarendse]

This is indeed by design, as the Nested Content data type configuration only stores the selected group name, which can only be unique for generic groups (you can have multiple groups with the same name below different tabs). Besides that, because Nested Content only supports showing properties, allowing you to select a tab would give the wrong expectation that it would show all the groups within that tab as well 😕

The Block List editor supports tabs, so adding them to element types is a valid structure (and shouldn't be prevented).

I'm sure we can make this more clear (and friendly) by adding a message to the Nested Content data type configuration if the dropdown is empty, something along the lines of: "The selected element type does not contain any supported groups (tabs are not supported by this editor, either change them to groups or use the Block List editor).". Updating the documentation is also a great way to contribute (especially during Hacktober) 😃

[nul800sebastiaan]

I've put this one up for grabs with Ronald's guidance in the previous comment. Please note that while this is marked as v9, we should have the PR for v8 since it affects that too. We will merge up to v9 and any PRs will count for Umbraco Hacktoberfest.

[IbrahimMNada]

this PR is made for V8 as @nul800sebastiaan 's Request

#11493

and this PR is on V9 before i read @nul800sebastiaan 's request 😆
#11483

[umbrabot]

Hiya @BarryFogarty,

Just wanted to let you know that we noticed that this issue got a bit stale and might not be relevant any more.

We will close this issue for now but we're happy to open it up again if you think it's still relevant (for example: it's a feature request that's not yet implemented, or it's a bug that's not yet been fixed).

To open it this issue up again, you can write @umbrabot still relevant in a new comment as the first line. It would be super helpful for us if on the next line you could let us know why you think it's still relevant.

For example:

@umbrabot still relevant
This bug can still be reproduced in version x.y.z

This will reopen the issue in the next few hours.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂