Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub issue#11299 fix #11483

Closed
wants to merge 2 commits into from
Closed

GitHub issue#11299 fix #11483

wants to merge 2 commits into from

Conversation

IbrahimMNada
Copy link
Contributor

Prerequisites

Issue Description In The Attached Bug :

#11299

Summary : we just need to add a message to tell the User that the Nested Content is not supporting the Tabs in the document types

Fix Steps :

-A new tooltip paragraph is added
image

-When the user chose a zero tabbed Document type it shows the following message :

image

-If there are groups the flow will be normal as always :

image

@umbrabot
Copy link

Hi there @uppercuut, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@ronaldbarendse
Copy link
Contributor

I'll close this PR in favor of #11493 that can be merged up to v9 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants