#10274 Variant sorting should take into account that there might not be any language #10278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested the following dialogs with only segments allowed:
The same dialogs has also been tested with both languages and segments allowed. |
madsrasmussen
deleted the
v8/bugfix/10274-make-sorting-work-when-no-language
branch
nul800sebastiaan
pushed a commit
that referenced
this pull request
May 19, 2021
…be any language (#10278) (#10284) Co-authored-by: Niels Lyngsø <[email protected]> Co-authored-by: Mads Rasmussen <[email protected]>
nul800sebastiaan
pushed a commit
that referenced
this pull request
May 19, 2021
…be any language (#10278) * Variant sorting should take into account that there might not be any language available * fix languages Co-authored-by: Niels Lyngsø <[email protected]> Co-authored-by: Mads Rasmussen <[email protected]> (cherry picked from commit e19a598)
nul800sebastiaan
pushed a commit
that referenced
this pull request
May 19, 2021
…be any language (#10278) (#10284) Co-authored-by: Niels Lyngsø <[email protected]> Co-authored-by: Mads Rasmussen <[email protected]> (cherry picked from commit 017b56e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that language is available before testing on the properties of it.
test-notes etc can be found on issue:
Fixes #10274
Follow the instructions in this PR to get segments set up: #7973