Fix macOS build errors; fv3atm: register diagnostics from stochastic physics only if allocated; ccpp-physics: cleanup CCPP cmake flags part 1 #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r-model into cleanup-ccpp-test-gfdlmp-split-clw
…om/climbfuji/ufs-weather-model into cleanup-ccpp-test-gfdlmp-split-clw
climbfuji
requested review from
junwang-noaa,
DeniseWorthen and
DusanJovic-NOAA
climbfuji
changed the title
climbfuji
changed the title
climbfuji
added
hera-gnu-BL
Baseline Updates
junwang-noaa
approved these changes
Nov 10, 2021
DeniseWorthen
approved these changes
Nov 10, 2021
|
All regression tests, CI tests and OpnReqTests passed. Will merge ccpp-physics. |
|
Ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.
New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.
Description
This PR updates the submodule pointers for fv3atm and ccpp-physics for the changes described in NOAA-EMC/fv3atm#417, NCAR/ccpp-physics#768 and NCAR/ccpp-physics#769:
README.mdin ccpp-physicsRemoving the special lowering of AVX2 flags to AVX-I for
radiation_aerosols.frequires new baselines for all tests with the Intel compiler. Other changes do not affect the results (verified by testing the AVX2 --> AVX-I changes in isolation first, then adding the other changes on top). In particular, results do not change with the GNU compiler.Issue(s) addressed
Fixes #309
Fixes #895
Testing
Full regression tests will be run on all tier-1 platforms when it is time to commit.
Dependencies