-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WORK IN PROGRESS - Update convective transportable tracer handling for GFDL-MP #768
Conversation
…like Zhao-Carr w.r.t. convective transportable tracers
…nup-ccpp-test-gfdlmp-split-clw
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only reviewed the README file. Looks good, thanks for updating it. The only question I have it whether it is necessary to have the author and date of the last update. Typically this information can be provided by GutHub, without needing to be embedded in the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good.
…mes in physics/GFS_suite_interstitial.F90
…nup-ccpp-test-gfdlmp-split-clw
This PR is not necessary, based on the discussion in issue #769. |
Description
This PR fixes #769. See the issue for a comprehensive description of the problem and the solution implemented here.
The PR also updates the top-level
README.md
, which is in dire need of being updated. (NOTE this may be included in another PR before this PR goes in)Associated PRs
n/a
Testing
See n/a