Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WORK IN PROGRESS - Update convective transportable tracer handling for GFDL-MP #768

Closed

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Nov 4, 2021

Description

This PR fixes #769. See the issue for a comprehensive description of the problem and the solution implemented here.

The PR also updates the top-level README.md, which is in dire need of being updated. (NOTE this may be included in another PR before this PR goes in)

Associated PRs

n/a

Testing

See n/a

Copy link
Contributor

@panll panll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part looks good to me.

Copy link
Collaborator

@ligiabernardet ligiabernardet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only reviewed the README file. Looks good, thanks for updating it. The only question I have it whether it is necessary to have the author and date of the last update. Typically this information can be provided by GutHub, without needing to be embedded in the file.

Copy link
Collaborator

@JongilHan66 JongilHan66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good.

@climbfuji climbfuji changed the title Update convective transportable tracer handling for GFDL-MP WORK IN PROGRESS - Update convective transportable tracer handling for GFDL-MP Dec 29, 2021
@climbfuji climbfuji marked this pull request as draft December 29, 2021 17:24
@climbfuji
Copy link
Collaborator Author

This PR is not necessary, based on the discussion in issue #769.

@climbfuji climbfuji closed this Dec 29, 2021
@climbfuji climbfuji deleted the cleanup-ccpp-test-gfdlmp-split-clw branch June 27, 2022 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update convective transportable tracer handling for GFDL-MP
4 participants