-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fourth reconciliation PR from production/RRFS.v1 + Add PIO switch to WW3 to avoid build errors #2512 #2483
Fourth reconciliation PR from production/RRFS.v1 + Add PIO switch to WW3 to avoid build errors #2512 #2483
Conversation
Note: As discussed with @masih-e @danrosen25 @pedro-jm, this PR, together with changes in #2481 fixes a problem in the new fire behavior regression test (cpld_regional_atm_fbh) whereby the values of kinematic_surface_upward_sensible_heat_flux_of_fire, surface_upward_specific_humidity_flux_of_fire, and smoke_emission_of_fire are not correctly being transferred from the fire behavior module to the CCPP physics because of an error in CCPP metadata. |
@grantfirl can you sync up the branches? We can start working on this pr. #2512 (hotfix for PIO WW3 build issue and no impact on baselines) can be combined into this pr. Just need to point to https://github.com/JessicaMeixner-NOAA/WW3/tree/bug/addPIOswitch |
Finished syncing and combining #2512. |
@FernandoAndrade-NOAA NOAA-EMC/WW3/pull/1324 has been merged. |
@grantfirl the fv3 pr was merged: new hash NOAA-EMC/fv3atm@1648e17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WW3 commit hash looks good. Thank you @grantfirl and @jkbk2004 for including the WW3 fix in this PR!!
Commit Queue Requirements:
Description:
This PR bring the changes from #2170 into the develop branch and is work from @haiqinli.
-- Update the MYNN PBL, Smoke and subgrid cloud fraction for the RRFS.v1 code freeze.
-- Merge the bugfix in the HAILCAST diagnostic code (unit issue)
This PR also combines changes from #2512
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
Library Changes/Upgrades:
Testing Log: