Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fourth reconciliation PR from produciton/RRFS.v1 #363

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

grantfirl
Copy link

@grantfirl grantfirl commented Oct 29, 2024

Description

This PR bring the changes from NOAA-EMC#87 into the dev/emc branch.

This work is from @haiqinli and includes changes to the smoke and dust output.

How Has This Been Tested?

This work has been run through UFS WM regression tests on Hera.

Checklist:

Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@laurenchilutti
Copy link
Contributor

@grantfirl is there anyone that you would specifically like to review this?

@grantfirl
Copy link
Author

@grantfirl is there anyone that you would specifically like to review this?

@laurenchilutti Not particularly -- just whomever is in charge of the NGGPS diagnostics file, I suppose.

@FernandoAndrade-NOAA
Copy link

Testing on #2483 has completed successfully, please continue with the merge process.

@laurenchilutti laurenchilutti merged commit 9490871 into NOAA-GFDL:dev/emc Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants