Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fourth reconciliation PR from production/RRFS.v1 #883

Merged
merged 14 commits into from
Dec 6, 2024

Conversation

grantfirl
Copy link
Collaborator

@grantfirl grantfirl commented Oct 29, 2024

Description

This work corresponds to #802 merged into production/RRFS.v1, except this is targeted at the develop branch. This was @haiqinli 's work.

-- Update the MYNN PBL, Smoke and subgrid cloud fraction for the RRFS.v1 code freeze.
-- New (not in RRFSv1): update ccpp-framework commit hash (only updates required cmake version)

What bug does it fix, or what feature does it add?
-- Merge the bugfix in the HAILCAST diagnostic code (unit issue) (#320)
-- Merge (#801)

Is a change of answers expected from this PR? Yes.

Issue(s) addressed

Non

Testing

Original testing for production/RRFS.v1 merge:

How were these changes tested? The changes were tested with retro runs and regression test.

What compilers / HPCs was it tested with? Intel compiler on Hera and Jet.

Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Yes.

Have the ufs-weather-model regression test been run? On what platform? Yes, on Hera.

Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
Yes, because the physics changed.
Please commit the regression test log files in your ufs-weather-model branch
Yes, the regression test log file was committed.

New testing for develop branch merge:
Ran full rt.conf on Hera. The test_changes.list and RT log were pushed into the UFSWM PR.

Dependencies

ufs-community/ccpp-physics#230

Requirements before merging

  • All new code in this PR is tested by at least one unit test
  • All new code in this PR includes Doxygen documentation
  • All new code in this PR does not add new compilation warnings (check CI output)

@DusanJovic-NOAA
Copy link
Collaborator

@grantfirl Can you please update ccpp-framework hash in one of your 'reconciliation' PRs to point to the top of the main branch. There has been only one commit that updates minimum cmake version to eliminate come cmake warnings. See NCAR/ccpp-framework#611

@grantfirl
Copy link
Collaborator Author

@grantfirl Can you please update ccpp-framework hash in one of your 'reconciliation' PRs to point to the top of the main branch. There has been only one commit that updates minimum cmake version to eliminate come cmake warnings. See NCAR/ccpp-framework#611

Of course. I'll do it here.

@jkbk2004 jkbk2004 merged commit 1648e17 into NOAA-EMC:develop Dec 6, 2024
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants