Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

negative precipitation with stochastic physics #58

Closed
pjpegion opened this issue Mar 19, 2020 · 8 comments
Closed

negative precipitation with stochastic physics #58

pjpegion opened this issue Mar 19, 2020 · 8 comments

Comments

@pjpegion
Copy link

Currently, there may be negative rain or snow being passed to the ocean and ice when SPPT is enabled. This is because of the inconsistency between the partitioning of the rain/snow and the rain/snow tendency.

The fix requires modifications to fv3_atm: FV3/gfsphysics/GFS_layer/GFS_physics_driver.F90 (for IPD)
and ccpp_physics: FV3/ccpp/physics/physics/GFS_MP_generic.F90 (for CCPP).

@junwang-noaa
Copy link
Collaborator

Phil,

Would you please create an issue at fv3atm repo so we know the changes are coming?

@climbfuji
Copy link
Collaborator

@pjpegion I believe this issue has been solved. Please check and if so, close it. Thanks!

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Mar 30, 2020 via email

@climbfuji
Copy link
Collaborator

I am not intending to include this update in the S2s PR.

@pjpegion
Copy link
Author

pjpegion commented Mar 30, 2020 via email

@climbfuji
Copy link
Collaborator

Oh - got it. Thanks. Will hopefully be merged soon.

@DeniseWorthen
Copy link
Collaborator

@pjpegion Can this issue be closed on the ufs-s2s-model?

@pjpegion
Copy link
Author

pjpegion commented May 6, 2020

yes.

@pjpegion pjpegion closed this as completed May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants