Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

negative precipitation with stochastic physics when coupled #84

Closed
pjpegion opened this issue Mar 23, 2020 · 1 comment
Closed

negative precipitation with stochastic physics when coupled #84

pjpegion opened this issue Mar 23, 2020 · 1 comment

Comments

@pjpegion
Copy link
Collaborator

Currently, there may be negative rain or snow being passed to the ocean and ice when SPPT is enabled. This is because of the inconsistency between the partitioning of the rain/snow and the rain/snow tendency.

The fix requires modifications to ccpp_physics: FV3/ccpp/physics/physics/GFS_MP_generic.F90 There will also be a separate pull request for the IPD side. This is related to
ufs-community/ufs-s2s-model#58
Phil
@climbfuji
Copy link
Collaborator

@pjpegion I believe this issue has been solved. Please check and if so, close it. Thanks!

climbfuji pushed a commit to climbfuji/fv3atm that referenced this issue Apr 23, 2021
@DomHeinzeller
Merge pull request NOAA-EMC#84 from climbfuji/move_plumrise_to_gocart…
ad0aa26 
…_repo

Add dependency of ccpp-physics on gocart library to CMakeLists.txt
SamuelTrahanNOAA referenced this issue in SamuelTrahanNOAA/fv3atm Jun 13, 2022
@climbfuji
Update EMC develop from NCAR dtc/develop 2020/03/17 (NCAR#84)
44604a0 
* hera.gnu build target with regression test config rt_gnu.conf (same as used on Cheyenne); this initial version uses the UFS public release v1.0.0 NCEPLIBS
* re-enable IPD REPRO, CCPP REPRO, CCPP PROD regression tests; IPD REPRO and CCPP REPRO are bit-for-bit identical
* bugfixes for some CCPP regression tests (IAU dry mass fixer)
* addition of two-way coupled CCPP regression tests, removal of old IPD Thompson test, addition of several debug tests (Thompson non-aero and GSD suite) to cover more physics options in DEBUG mode
* change logic in rt.sh that COMPILE or APPBUILD lines without a machine name are executed on all machines (similar to what is done for the RUN lines)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@climbfuji @pjpegion