-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transition CCPP to ufs-s2s-model (contains #7) #64
Transition CCPP to ufs-s2s-model (contains #7) #64
Conversation
compsets/all_ccpp.input compsets/cpld_fv3_ccpp_mom6_cice_2d_atm_flux.input compsets/cpld_fv3_ccpp_mom6_cice_cold_atm_flux.input compsets/fv3mom6cice5_ccpp.input coupledFV3_CCPP_MOM6_CICE.appBuilder
…of regression test baseline
…rectories iteratively from rtgen.PID directories
… (Regain bit-for-bit identical results between IPD and CCPP for coupled model runs)
compsets/fv3mom6cice5.input
Outdated
@@ -61,7 +61,7 @@ build fv3_mom6_cice.exe { | |||
|
|||
# The NEMSAppBuilder is another embedded bash script in nemscommon.input | |||
build=NEMSAppBuilder(NEMS.x="@[target]",modules.nems="@[modules.nems]", | |||
OPTS="app=coupledFV3_MOM6_CICE",md5sum="@[md5sum]") | |||
OPTS="app=coupledFV3_MOM6_CICE rebuild",md5sum="@[md5sum]") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is "rebuild" added here? In https://github.com/ufs-community/ufs-s2s-model/blob/develop/compsets/nemscommon.input#L34 we have that all builds have to "rebuild"? This was added in the last commit because when adding a build with WW3, it was required that we rebuild always or we were having issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. I think this was by coincidence after creating the CCPP versions and then trying to make them look the same. I can revert this change (and make the same change on the CCPP side).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that the "rebuild" can then be removed from the other build commands as well, or, given that it is in nemscommon.input?
Jessica,
Does this mean we have to have a clean build every time when we build the
model? This could cause lots of inconvenience for debugging. So if this is
the case, can we have a separate build for fv3-mom6-cice5-wave for 4
components test and an fv3-mom6-cice5 executable for 3 component tests
until the issue with rebuild fv3-mom6-cice5-wave is resolved?
…On Mon, Mar 30, 2020 at 11:03 AM Dom Heinzeller ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In compsets/fv3mom6cice5.input
<#64 (comment)>
:
> @@ -61,7 +61,7 @@ build fv3_mom6_cice.exe {
# The NEMSAppBuilder is another embedded bash script in nemscommon.input
***@***.******@***.***",
- ***@***.***")
+ OPTS="app=coupledFV3_MOM6_CICE ***@***.***")
It seems that the "rebuild" can then be removed from the other build
commands as well, or, given that it is in nemscommon.input?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#64 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TPLTH2B446X32OCXZ3RKCYETANCNFSM4LVCESMQ>
.
|
…build' in NEMSAppBuilder commands
Commit d179cc3 updates the baseline on hera (revert to new official baseline dir) and removes the redundant "rebuild" flags in the individual app builder sections. |
Using compile.sh is way simpler!
…On Mon, Mar 30, 2020 at 11:11 AM Jun Wang ***@***.***> wrote:
Jessica,
Does this mean we have to have a clean build every time when we build the
model? This could cause lots of inconvenience for debugging. So if this is
the case, can we have a separate build for fv3-mom6-cice5-wave for 4
components test and an fv3-mom6-cice5 executable for 3 component tests
until the issue with rebuild fv3-mom6-cice5-wave is resolved?
On Mon, Mar 30, 2020 at 11:03 AM Dom Heinzeller ***@***.***>
wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In compsets/fv3mom6cice5.input
> <
#64 (comment)
>
> :
>
> > @@ -61,7 +61,7 @@ build fv3_mom6_cice.exe {
>
> # The NEMSAppBuilder is another embedded bash script in nemscommon.input
> ***@***.******@***.***",
> - ***@***.***")
> + OPTS="app=coupledFV3_MOM6_CICE ***@***.***")
>
> It seems that the "rebuild" can then be removed from the other build
> commands as well, or, given that it is in nemscommon.input?
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <
#64 (comment)
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AI7D6TPLTH2B446X32OCXZ3RKCYETANCNFSM4LVCESMQ
>
> .
>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#64 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALLVRYT2BCKU3BR7STVKSL3RKCZALANCNFSM4LVCESMQ>
.
--
Dr. Shrinivas Moorthi
Research Meteorologist
Modeling and Data Assimilation Branch
Environmental Modeling Center / National Centers for Environmental
Prediction
5830 University Research Court - (W/NP23), College Park MD 20740 USA
Tel: (301)683-3718
e-mail: [email protected]
Phone: (301) 683-3718 Fax: (301) 683-3718
|
So @junwang-noaa, you're suggesting we should remove the default rebuild setting from nemscommon.input and re-insert it to the individual app build files but only for the 4-component cases. I would agree w/ that approach. |
Tell me ... |
@junwang-noaa Yes, we have to have a clean build every time when we build the |
I suggest no further trials and experiments with this PR, except for running a final round of regression tests after updating the baseline location and finishing the code review. It will be way cheaper and quicker to experiment with this after removing the IPD PROD, IPD REPRO and CCPP REPRO tests. |
You need updated compil.sh - see my ufs-s2s-model branch "SM_Feb252020"
under tests directory. All you have to do is then
"compile.sh $yourdir/FV3 hera.intel 'CCPP=Y HYBRID=N STATIC=Y
SUITES=FV3_GFS_cpld_rasmgshoc MOM6=Y CICE=Y WW3=Y ' ccpp YES NO"
This then can compile FV3, FV3+WW3, FV3+MOM6+CICE5, or FV3+MOM6+CICE5+WW3
and CCPP or IPD.
The argument "ccpp" is not really working right now, the executable will be
under "NEMS/exe"
I modified the conf files so that we only need one conf file and one module
file; no need to carry duplicate files.
In my opinion, ufs-s2s-model and ufs-weather-model can be merged.
Moorthi
…On Mon, Mar 30, 2020 at 11:30 AM Dom Heinzeller ***@***.***> wrote:
Using compile.sh is way simpler!
… <#m_2702153625981825713_>
Tell me ...
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#64 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALLVRYT4RHQYUK5PAPOBKETRKC3JNANCNFSM4LVCESMQ>
.
--
Dr. Shrinivas Moorthi
Research Meteorologist
Modeling and Data Assimilation Branch
Environmental Modeling Center / National Centers for Environmental
Prediction
5830 University Research Court - (W/NP23), College Park MD 20740 USA
Tel: (301)683-3718
e-mail: [email protected]
Phone: (301) 683-3718 Fax: (301) 683-3718
|
Thanks, Moorthi. That's great if we can have one compile.sh (also
same module load file) for both weather and s2s applications! So what is
the "ccpp" for in your compile.sh?
On Mon, Mar 30, 2020 at 11:39 AM SMoorthi-emc <[email protected]>
wrote:
… You need updated compil.sh - see my ufs-s2s-model branch "SM_Feb252020"
under tests directory. All you have to do is then
"compile.sh $yourdir/FV3 hera.intel 'CCPP=Y HYBRID=N STATIC=Y
SUITES=FV3_GFS_cpld_rasmgshoc MOM6=Y CICE=Y WW3=Y ' ccpp YES NO"
This then can compile FV3, FV3+WW3, FV3+MOM6+CICE5, or FV3+MOM6+CICE5+WW3
and CCPP or IPD.
The argument "ccpp" is not really working right now, the executable will be
under "NEMS/exe"
I modified the conf files so that we only need one conf file and one module
file; no need to carry duplicate files.
In my opinion, ufs-s2s-model and ufs-weather-model can be merged.
Moorthi
On Mon, Mar 30, 2020 at 11:30 AM Dom Heinzeller ***@***.***>
wrote:
> Using compile.sh is way simpler!
> … <#m_2702153625981825713_>
>
> Tell me ...
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <
#64 (comment)
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/ALLVRYT4RHQYUK5PAPOBKETRKC3JNANCNFSM4LVCESMQ
>
> .
>
--
Dr. Shrinivas Moorthi
Research Meteorologist
Modeling and Data Assimilation Branch
Environmental Modeling Center / National Centers for Environmental
Prediction
5830 University Research Court - (W/NP23), College Park MD 20740 USA
Tel: (301)683-3718
e-mail: ***@***.***
Phone: (301) 683-3718 Fax: (301) 683-3718
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#64 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TPOWUDBOCX7G2X7NDLRKC4KFANCNFSM4LVCESMQ>
.
|
Could I request that we not move the conversation off the topic of this PR for now? |
For now it has no use, just a placeholder. In ufs-weather model this
argument copies the executable to the test directory with that name right?
I didn't figure out where this copy occurs, but I guess it could be at the
end of compile.sh
Or, we could stay with "NEMS.x" and forget about that argument.
…On Mon, Mar 30, 2020 at 11:50 AM Jun Wang ***@***.***> wrote:
Thanks, Moorthi. That's great if we can have one compile.sh (also
same module load file) for both weather and s2s applications! So what is
the "ccpp" for in your compile.sh?
On Mon, Mar 30, 2020 at 11:39 AM SMoorthi-emc ***@***.***>
wrote:
> You need updated compil.sh - see my ufs-s2s-model branch "SM_Feb252020"
> under tests directory. All you have to do is then
> "compile.sh $yourdir/FV3 hera.intel 'CCPP=Y HYBRID=N STATIC=Y
> SUITES=FV3_GFS_cpld_rasmgshoc MOM6=Y CICE=Y WW3=Y ' ccpp YES NO"
> This then can compile FV3, FV3+WW3, FV3+MOM6+CICE5, or FV3+MOM6+CICE5+WW3
> and CCPP or IPD.
> The argument "ccpp" is not really working right now, the executable will
be
> under "NEMS/exe"
> I modified the conf files so that we only need one conf file and one
module
> file; no need to carry duplicate files.
> In my opinion, ufs-s2s-model and ufs-weather-model can be merged.
> Moorthi
>
> On Mon, Mar 30, 2020 at 11:30 AM Dom Heinzeller <
***@***.***>
> wrote:
>
> > Using compile.sh is way simpler!
> > … <#m_2702153625981825713_>
> >
> > Tell me ...
> >
> > —
> > You are receiving this because you commented.
> > Reply to this email directly, view it on GitHub
> > <
>
#64 (comment)
> >,
> > or unsubscribe
> > <
>
https://github.com/notifications/unsubscribe-auth/ALLVRYT4RHQYUK5PAPOBKETRKC3JNANCNFSM4LVCESMQ
> >
> > .
> >
>
>
> --
> Dr. Shrinivas Moorthi
> Research Meteorologist
> Modeling and Data Assimilation Branch
> Environmental Modeling Center / National Centers for Environmental
> Prediction
> 5830 University Research Court - (W/NP23), College Park MD 20740 USA
> Tel: (301)683-3718
>
> e-mail: ***@***.***
> Phone: (301) 683-3718 Fax: (301) 683-3718
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <
#64 (comment)
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AI7D6TPOWUDBOCX7G2X7NDLRKC4KFANCNFSM4LVCESMQ
>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#64 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALLVRYT3DPKJJAU45EVA4E3RKC5ULANCNFSM4LVCESMQ>
.
--
Dr. Shrinivas Moorthi
Research Meteorologist
Modeling and Data Assimilation Branch
Environmental Modeling Center / National Centers for Environmental
Prediction
5830 University Research Court - (W/NP23), College Park MD 20740 USA
Tel: (301)683-3718
e-mail: [email protected]
Phone: (301) 683-3718 Fax: (301) 683-3718
|
Jessica,
I see your point. So we do want to have clean build for RT tests. Can you
clarify if the fv3-mom6-cice5-ww3 rebuild is working correctly or not?
…On Mon, Mar 30, 2020 at 11:55 AM Denise Worthen ***@***.***> wrote:
Could I request that we not move the conversation off the topic of this PR
for now?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#64 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TPF5KWILV5VIFAYII3RKC6GZANCNFSM4LVCESMQ>
.
|
@junwang-noaa if you use the "rebuild" option everything works fine. If you do not use the "rebuild" option we are still having issues when using WW3 and I have not tracked down that issue or resolved it yet. |
I am confused, are you saying we should build with "rebuild" for
fv3-mom6-cice5-ww3 exe? Currently in Dom's code:
target="@[plat%EXECrt]/fv3_mom6_cice_ww3.exe"
modules.nems="@[plat%INCrt]/modules_fv3_mom6_cice_ww3"
md5sum="@[target].md5"
# The NEMSAppBuilder is another embedded bash script in nemscommon.input
build=NEMSAppBuilder(NEMS.x="@[target]",modules.nems="@[modules.nems]",
OPTS="app=coupledFV3_MOM6_CICE_WW3",md5sum="@[md5sum]")
how does this build (without rebuild) impact the related tests with or
without ww3?
…On Mon, Mar 30, 2020 at 12:05 PM Jessica Meixner ***@***.***> wrote:
@junwang-noaa <https://github.com/junwang-noaa> if you use the "rebuild"
option everything works fine. If you do not use the "rebuild" option we are
still having issues when using WW3 and I have not tracked down that issue
or resolved it yet.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#64 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TM3K5FTK6B732XFHA3RKC7LLANCNFSM4LVCESMQ>
.
|
@junwang-noaa Since we have "rebuild" as the default option in compsets/nemscommon.input we do not need to specify build or rebuild in build sections in compsets/fv3mom6cice5.input But if we do specify them there, then it should be there for both the fv3mom6cice5.exe and the fv3mom6cice5ww3.exe |
I checked the code, currently in NEMSAppBuild, specify "rebuild" or specify
nothing are the same, the code will build from the beginning. So adding
"rebuild" or not does not make difference.
…On Mon, Mar 30, 2020 at 12:49 PM Jessica Meixner ***@***.***> wrote:
I am confused, are you saying we should build with "rebuild" for
fv3-mom6-cice5-ww3 exe? Currently in Dom's code:
***@***.***%EXECrt]/fv3_mom6_cice_ww3.exe"
***@***.***%INCrt]/modules_fv3_mom6_cice_ww3"
***@***.***.md5" # The NEMSAppBuilder is another embedded bash script
in nemscommon.input
***@***.******@***.***",
***@***.***") how does this build
(without rebuild) impact the related tests with or without ww3?
… <#m_5530479515465897229_>
@junwang-noaa <https://github.com/junwang-noaa> Since we have "rebuild"
as the default option in compsets/nemscommon.input we do not need to
specify build or rebuild in build sections in compsets/fv3mom6cice5.input
But if we do specify them there, then it should be there for both the
fv3mom6cice5.exe and the fv3mom6cice5ww3.exe
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#64 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TMHLWOEJWCT55XNOTDRKDESBANCNFSM4LVCESMQ>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for all the effort to create multiple RTs.
@DeniseWorthen thanks for checking the PR thoroughly, in particular the issue about defining |
Regression tests on hera.intel using NEMSCompsetRun all passed (after removing the redundant "rebuild" flags and changing the regression test baseline back to the official location, i.e. for the code as it is now in the PR). Logs updated in the repository. This PR is ready to merge from my side. |
Thank you all! Let's wait for the 8 long run cases to finish, if there is
no problem there, I think we can commit the code.
…On Mon, Mar 30, 2020 at 8:01 PM BinLi-NOAA ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#64 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TOKLQ22T3BFKTQSRXLRKEXFPANCNFSM4LVCESMQ>
.
|
@JessicaMeixner-NOAA if your runs are stuck in the queue I can help, just need your instructions or copy the already set up directories. |
…component and need to remove %DEBUG=Y decorator from FV3 or FV3_MAKEOPT is ignored
This PR contains and expands upon the original PR from @panll #7.