Run precheck on addition of closing keyword

[ishowvel]

Resolves #5, Resolves #4

[ishowvel]

qa ishowvel-org/.ubiquity-os#82

[ishowvel]

@0x4007 this pull request also fixes #4, can a single pull request be linked to multiple issues?

[0x4007]

@0x4007 this pull request also fixes #4, can a single pull request be linked to multiple issues?

Because it is a tiny <15 minute task I will allow for an exception but normally you'll need to cherry pick changes and make a new pull (this usually is pretty quick to do.)

[0x4007]

qa ishowvel-org/.ubiquity-os#82

Looks like it ran after converting to a draft which is wrong.

Reviewing again it seems that you did several events in quick succession. As I understand it ran because you edited the pull body to link it to the issue at the same time as turning it into a draft.

[whilefoo]

Reviewing again it seems that you did several events in quick succession. As I understand it ran because you edited the pull body to link it to the issue at the same time as turning it into a draft.

The plugin is the one which converted to a draft and left a review

[ishowvel]

qa ishowvel-org/.ubiquity-os#82

Looks like it ran after converting to a draft which is wrong.

Reviewing again it seems that you did several events in quick succession. As I understand it ran because you edited the pull body to link it to the issue at the same time as turning it into a draft.

The events that happened were
The pull request was opened with no issue linked to it and precheck was not ran
Pull body was edited to link an issue via closing keyword, precheck was ran which left a review and converted the pull request to draft

[ishowvel]

@0x4007 this pull request also fixes #4, can a single pull request be linked to multiple issues?

Because it is a tiny <15 minute task I will allow for an exception but normally you'll need to cherry pick changes and make a new pull (this usually is pretty quick to do.)

It might become a bit too cluttered, I'll make a separate pull request and move changes from this pr to the new one tomorrow

[0x4007]

@0x4007 this pull request also fixes #4, can a single pull request be linked to multiple issues?

Because it is a tiny <15 minute task I will allow for an exception but normally you'll need to cherry pick changes and make a new pull (this usually is pretty quick to do.)

It might become a bit too cluttered, I'll make a separate pull request and move changes from this pr to the new one tomorrow

Its fine for this time you can leave as is.

[whilefoo]

Please show QA

[ishowvel]

ishowvel-org/.ubiquity-os#83 @whilefoo