Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

non openai endpoint #82

Closed
wants to merge 1 commit into from
Closed

non openai endpoint #82

wants to merge 1 commit into from

Conversation

ishowvel
Copy link
Collaborator

@ishowvel ishowvel commented Feb 4, 2025 •
edited
Loading

Closes #76 fixes #74

@ishowvel
Copy link
Collaborator Author

ishowvel commented Feb 4, 2025

issues isnt linked, hasnt run precheck

@ubiquibot-ishowvel ubiquibot-ishowvel bot marked this pull request as draft February 4, 2025 11:02
ubiquibot-ishowvel[bot]
ubiquibot-ishowvel bot requested changes Feb 4, 2025
View reviewed changes
Copy link

@ubiquibot-ishowvel ubiquibot-ishowvel bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request does not meet the specifications. It should default to the full OpenAI URL and allow for swapping of relevant parts when a value is provided, instead of appending or using a non-OpenAI endpoint by default.

@ishowvel ishowvel mentioned this pull request Feb 4, 2025
Open
@ishowvel ishowvel marked this pull request as ready for review February 5, 2025 11:48
@ishowvel ishowvel closed this Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubiquibot-ishowvel ubiquibot-ishowvel[bot] ubiquibot-ishowvel[bot] requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default Endpoint Is "" Logic Be Fixed qa for review incentivizer
1 participant
@ishowvel