Always run when pull opened

[0x4007]

Sometimes authors don't open their pulls as drafts and as I understand this plugin only runs when converting from draft to regular pull.

The idea is that errors should not be thrown unless an actual error occurred. Errors shouldn't make the plugin annoying or impose where it's not needed. An example of this is the previous issue I filed in this repo #4

This should run when a specification is linked. So this includes on link event and/or when the pull body is edited to include a closing keyword.

Also I suppose that we should run the precheck when the pull is opened as well, even if it isn't a draft.

Originally posted by @0x4007 in ubiquity-os-marketplace/command-ask#58 (comment)

[ubiquity-os-beta]

Note

The following contributors may be suitable for this task:

ishowvel

80% Match ubiquity-os/plugins-wishlist#45

gentlementlegen

77% Match ubiquity-os-marketplace/daemon-disqualifier#64
76% Match ubiquity-os-marketplace/daemon-disqualifier#59

[0x4007]

@ishowvel are you interested to make this adjustment?

[ishowvel]

So refactoring some errors to just be warnings so that issues don't get spammed with bot comments and running pull precheck on pulls no matter the state?

[ishowvel]

/start

[ubiquity-os-beta]

! 

[gentlementlegen]

^ the run was okay, only the display I messed up (which I fixed in ubiquity-os-marketplace/command-start-stop#133)

Error was
�[33m ⚠ You must be a core team member, or an administrator to start this task�[0m

[ishowvel]

/start

[ubiquity-os-beta]

! 

@gentlementlegen @whilefoo this metadata is messed up it says a function named "async" called it.

Aggregate error needs to be fixed

[ishowvel]

@0x4007 can I be assigned to this?

[ubiquity-os-beta]

Important

• Be sure to link a pull-request before the first reminder to avoid disqualification.
• Reminders will be sent every 1 day and 18 hours if there is no activity.
• Assignees will be disqualified after 3 days and 12 hours of inactivity.

[0x4007]

All plugins should try and be invisible as much as possible in normal GitHub use so they don't annoy our partners. So errors should only really throw when it's clear that the users are trying to use the feature. Commands are a great example where if you're using GitHub normally you're not writing these slash commands.

But things like opening pull requests is a bit more tricky so we need to be very strategic of when we throw errors. But I think since opening pulls is very normal for normal GitHub use, maybe we shouldn't throw errors at all.

[gentlementlegen]

The display was broken but the error was legitimate. The user could not be assigned to this task because it is reserved for collaborators and admins.

[ishowvel]

Changes are done, gonna push to pr with a qa by tomorrow