Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: a start message saying the bot is "thinking" is displayed #58

Open
wants to merge 15 commits into
base: development
Choose a base branch
from

Conversation

gentlementlegen
Copy link
Member

@gentlementlegen gentlementlegen commented Jan 29, 2025

Resolves #52

QA: Meniole#1 (comment)

I needed to add the capability to edit comments to this plugin. It should be using the SDK later on, but it required too much changes and fell out of scope of this issue.

@gentlementlegen gentlementlegen marked this pull request as ready for review January 29, 2025 03:10
@0x4007
Copy link
Member

0x4007 commented Jan 29, 2025

I needed to add the capability to edit comments to this plugin. It should be using the SDK later on, but it required too much changes and fell out of scope of this issue

To me it seems that it would be more important to standardize this across every plugin vs adding this custom capability. This is accruing tech debt.

But the feature is nice to have and I suppose the code changes are fine. It just seems that very little of the changes are actually related to the spec.


Also I suppose that we should run the precheck when the pull is opened as well, even if it isn't a draft.

@0x4007 0x4007 marked this pull request as draft January 29, 2025 04:32
@0x4007 0x4007 marked this pull request as ready for review January 29, 2025 04:33
@gentlementlegen
Copy link
Member Author

@0x4007 I started at first but it implied a lot of changes that went far beyond the spec. Also, I guess you noticed ubiquity-os/plugin-sdk#63 which will be handy to solve this as well, this is the only plugin so far that also will answer to comments in pull-request and pull-request reviews, which is not handled yet by the SDK postComment. Also, I did not want to touch it yet because the metadata is specific to be parsed later by the LLM it seems, so will have to carefully proceed. I can take care of it.

Copy link

@gentlementlegen, this task has been idle for a while. Please provide an update.

@gentlementlegen
Copy link
Member Author

@0x4007 Any update?

src/handlers/add-comment.ts Outdated Show resolved Hide resolved
@0x4007
Copy link
Member

0x4007 commented Feb 3, 2025

You can merge after 1. Naming the function and 2. Re enabling that linter setting

@@ -81,3 +103,5 @@ export async function addCommentToIssue(context: Context, message: string, optio
throw error;
}
}

addCommentToIssue.lastCommentId = undefined as number | undefined;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
addCommentToIssue.lastCommentId = undefined as number | undefined;
addCommentToIssue.lastCommentId = null;

Setting to undefined seems really unusual. Why not null

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve User Experience
3 participants