fix: linking a pull-request to un un-priced task does not get close #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x4007
reviewed
Jan 30, 2025
whilefoo
reviewed
Jan 30, 2025
tests/start.test.ts
Outdated
Comment on lines
206
to
210
| await expect(startStopTask(context)).rejects.toMatchObject({ | ||
| logMessage: { | ||
| raw: expect.stringContaining("This task does not reflect a business priority at the moment"), | ||
| }, | ||
| }); |
There was a problem hiding this comment.
this test can be deceiving because there could be both errors (no price label + no business priority) so you wouldn't actually know that it's not working
There was a problem hiding this comment.
Changed to strict equal: 03a9bdb
whilefoo
reviewed
Jan 31, 2025
| " › ```diff# These linked pull requests are closed: http://github.com/ubiquity/test-repo/pull/2 http://github.com/ubiquity/test-repo/pull/3" | ||
| ) | ||
| ); | ||
| expect(cleanLogString(logs[3])).toMatch(cleanLogString("›Closinglinkedpull-request.")); |
There was a problem hiding this comment.
Upgrading the logs package removed the diff display in favor of the CAUTION display. I think the cleanLogString removes spaces which is why it looks like this, and I didn't want to change all the tests, but I can in a separate PR.
whilefoo
approved these changes
Feb 1, 2025
gentlementlegen
merged commit 1253448
into
ubiquity-os-marketplace:development
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #129
QA: Meniole#60