MERGE TO PRODUCTION #90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[CHORES] setting up library
* [CHORES] add test dependencies * [CHORES] add database folder * [CHORES] disable badaso middleware to pass tests * [CHORES] load migration in LMSModuleProvider * [CHORES] create base TestCase class * [CHORES] provide example test class
* [CHORE] omit orchestra testbecnh * [CHORE] force package test to inherit directly from main app * [CHORE] re-enable badaso api middleware
…lms-module into PBI-3-view_class
* [RED] create test to create course without login * [GREEN] implement endpoint and handler to create course * [RED] create test when create course with valid data expect response status 200 * [GREEN] response course creation with ApiResponse success * [RED] create test to when create course with logged in user expect response with created course * [GREEN] implement create course response with request data * [RED] create test when create course expect course inserted into database * [GREEN] implement insertion into database when create course * [RED] create test when create course with valid data expect many to many relation created to user with role * [GREEN] implement create manyToMany relation to user when create course * [RED] create test when create course with invalid data expect response 422 * [GREEN] implement request validation when create course * [RED] create test when create course with invalid data expect no course or courseUser created * [GREEN] implement db transaction to avoid insertion when request failed * [CHORE] setting up factories and seeders * [REFACTOR] apply badaso pattern when handling error * [REFACTOR] utilize AuthHelper to ease user auth in tests
* [CHORES] Sonarquebe analysis * [CHORES] Add sonarqube properties * [REFACTOR] Remove unused variable on setup * [CHORES] Sonar scan on each branch * [CHORES] fix sonar branching * [CHORES] fix sonar branching * [CHORES] fix sonar branching * [CHORES] fix sonar branching * [CHORES] fix branch naming]
* [CHORES] add migrations and model for user login * [RED] initiate testing for user login * [CHORES] Check sonarqube analysis * [REFACTOR] Fix typin style * [CHORE] Sonarqube Coverage * [CHORE] Sonarqube Coverage * [CHORE] fix testing doesnt show up * [RED] changing user model to existing one * [RED] Fix login fail * [RED] Test for login api * [RED] Test able to login * [GREEN] Implement api for login * [REFACTOR] Applying fix from pr reply * [REFACTOR] Clean coding api route * [REFACTOR] Sonarqube code smell fix * [GREEN] All fucntionality done
* [CHORES] add migrations and model for user login * [RED] initiate testing for user login * [CHORES] Check sonarqube analysis * [REFACTOR] Fix typin style * [CHORE] Sonarqube Coverage * [CHORE] Sonarqube Coverage * [CHORE] fix testing doesnt show up * [RED] changing user model to existing one * [RED] Fix login fail * [RED] Test for login api * [RED] Test able to login * [GREEN] Implement api for login * [REFACTOR] Applying fix from pr reply * [REFACTOR] Clean coding api route * [REFACTOR] Sonarqube code smell fix * [GREEN] All fucntionality done * [REFACTOR] fix login succcesfull test * [REFACTOR] Fix style * [REFACTOR] Style from styleci * [REFACTOR] Style from styleci * [REFACTOR] Style from styleci
* [RED] Create test for user authorization * [RED] Create handleUserAuthorize test helper * [RED] Create handleCreateClass test helper * [RED] Create handleJoinClass test helper * [RED] Create withAuthorizeBearer test helper * [CHORES] Reset LMSJoinClassTest test cases * [REFACTOR] Delete test helper * [RED] Create testClassIsExist * [RED] Create testClassCodeValid * [RED] Create testClassCodeInvalid * [RED] Create joinClass empty function for ClassController * [RED] Create getClassCode empty function for ClassController * [CHORES] Change testing method * [RED] Create test when user is not authorized * [CHORES] Add git ignore configuration for composer.lock * [CHORES] Add configuration for testing * [RED] Create test to check if user is not authorized * [REFACTOR] Chance library import * [GREEN] Implement routing for join class but user is not authorized * [RED] Create test to join class but class-code is unknown * [RED] Create test to join class but class-code is unknown * [RED] Change assertioN * [RED] Change assertion * [RED] Create test for join class without no join code as input should return 400 error code * [RED] Create test to check if user is authorized and class code is valid should return status 200 * [RED] Create test to check if join class success should add student * [REFACTOR] Remove unused imports/variables * [GREEN] Implement join class controller * [REFACTOR] Remove unused imports * [REFACTOR] Reformat indentation spaces * [REFACTOR] Remove extra space * [REFACTOR] Change variables formatting into camelCase * [REFACTOR] Remove unnecessary query * [RED] Change assertion status when class not found * [GREEN] Return 404 status when course not found * [REFACTOR] Create course for testing by course factory * [CHORES] Create course factory * [REFACTOR] Remove extra whitespace * [REFACTOR] Reformat space indentation * [REFACTOR] StyleCI formatting * [REFACTOR] StyleCI formatting * [REFACTOR] StyleCI formatting * [REFACTOR] StyleCI formatting * [REFACTOR] Remove unused files
…lms-module into PBI-3-view_class
* [RED] create course detail api test * [GREEN] implement course detail api * [REFACTOR] add newline for styleci
* [RED] test create lesson material without login * [GREEN] implement add lesson material endpoint skeleton * [RED] test create lesson material in unenrolled course * [GREEN] only allow create lesson material in enrolled course * [RED] test create lesson material should only be done by teacher * [GREEN] restrict create lesson material can only be done by teacher * [RED] test create lesson material with no title * [GREEN] validate create lesson material, title is required * [RED] test create lesson material expect insert to database * [GREEN] implement insert to database on create lesson material * [RED] test create lesson material should return created object * [GREEN] response with created lesson material * [CHORE] reorder imports * [CHORE] change url to kebab-case
* [RED] test browse topic should responds with lesson materials * [GREEN] return lesson materials when browsing topic * [REFACTOR] refactor multple join query on browse announcements * [RED] test read lesson material should login * [GREEN] create read lesson materials endpoint with authorization * [RED] test read lesson material in unenrolled course * [GREEN] restrict read material lesson to users that enrolled the course * [RED] test read lesson material shuold response needed field * [GREEN] read lesson material responds needed fields * [CHORE] fix style CI * [CHORE] remove unneeded imports
* [RED] test edit lesson material should only be done by logged in user * [GREEN] define edit lesson material route * [RED] test edit lesson material by non-creator * [GREEN] implement edit lesson material only by creator * [RED] test edit lesson material when user has unenroll the course * [GREEN] only allow enrolled user to edit lesson material * [RED] test edit lesson material should update database * [GREEN] update database on edit lesson material * [RED] test edit lesson material should respond with updated lesson material * [GREEN] return updated lesson material on edit lesson material * [CHORE] fix style CI
* [RED] test delete lesson material without login * [GREEN] define delete lesson material route with authorization * [RED] test delete lesson material by non creator * [GREEN] forbid non-creator to delete lesson material * [RED] test delete lesson material should only be done by enrolled user * [GREEN] forbid unenrolled user to delete lesson material * [RED] test delete lesson material should delete it from db * [GREEN] delete lesson material from db * [RED] test delete lesson material should response 200 * [GREEN] return apiResponse success on delete lesson material
* [GREEN] Upload file * [RED] test file upload * [RED] Delete file test * [GREEN] Fix styleci * [GREEN] Fix styleci
* [CHORES] set up model * [CHORES] set up model * [RED] tests for create and retrieve material comments * [GREEN] implement create material comment * [GREEN] implement retrieve comments alongside its lesson material * [REFACTOR] fix code smell * [REFACTOR] naming conv and validation
* [RED] test browse topic should also return lessonMaterials with null topic * [GREEN] return lessonMaterials with topic null on browse topic * [CHORE] fix ci
* [RED] test when deleting topic, lesson material topic id should be null * [GREEN] fix lesson material migrations, set relation to topics table
* [REFACTOR] fix validation * [RED] create tests for edit and delete material comment * [GREEN] implements edit material comments * [GREEN] implements delete material comments * [GREEN] implements routing for edit delete material comment * [REFACTOR] fix code smell * [REFACTOR] npe handling
* [RED] test access create assignment * [GREEN] create assignment routes and controller skeleton * [RED] test create assignment in unenrolled course * [GREEN] forbid unenrolled user to create assignment * [RED] test create assignment as a student * [GREEN] restrict to only teacher who can create assignment * [RED] test create assignment with no title * [GREEN] make title required when creating assignment * [RED] test create assignment with no due date * [GREEN] make due date field required with certain format * [RED] test create assignment should insert to db * [GREEN] insert data to db on create assignment * [RED] test create assignment should return data * [GREEN] return created assignment on create assignment * [CHORE] fix style ci
* [RED] test access create assignment * [GREEN] create assignment routes and controller skeleton * [RED] test create assignment in unenrolled course * [GREEN] forbid unenrolled user to create assignment * [RED] test create assignment as a student * [GREEN] restrict to only teacher who can create assignment * [RED] test create assignment with no title * [GREEN] make title required when creating assignment * [RED] test create assignment with no due date * [GREEN] make due date field required with certain format * [RED] test create assignment should insert to db * [GREEN] insert data to db on create assignment * [RED] test create assignment should return data * [GREEN] return created assignment on create assignment * [CHORE] fix ci * [RED] test access read assignment route * [GREEN] define read assignment route * [RED] test read assignment in unenrolled course * [GREEN] only allow read assignment of enrolled course * [RED] test read assignment expect return data * [GREEN] responds the corresponding assignment on read * [RED] test browse all assignments via topic * [GREEN] return all assignments inside topics * [CHORE] fix style ci
* [RED] test access edit assignment route * [GREEN] define edit assignment route * [RED] test edit assignment not by creator * [GREEN] only allow creator to edit assignment * [RED] test edit assignment in a course by an unenrolled user * [GREEN] forbid unenrolled user to edit assignment * [RED] test edit assignment for valid case * [GREEN] update assignment on success validation * [RED] test edit assignment should return updated data * [GREEN] return data on success edit assignment * [CHORE] fix style ci
* [RED] test access delete assignment route * [GREEN] define delete assignment route * [RED] test delete assignment with unknown id * [GREEN] check assignment exists before delete * [RED] test delete assignment by non-creator * [GREEN] only allow creator to delete assignment * [RED] test delete assignment but user has unenrolled course * [GREEN] forbid user that has unenrolled course to delete assignment * [RED] test delete assignment should be deleted from db * [GREEN] delete from db on delete assignment * [RED] test delete assignment should response 200 if success * [GREEN] respond 200 on success delete assignment * [CHORE] fix style ci
* [REFACTOR] use iso8601 datetime format * [CHORE] fix style ci
* [RED] create and read tests for quiz * [GREEN] implements create quiz * [REFACTOR] update quiz tests * [GREEN] implements read quiz * [REFACTOR] fix code smell * [REFACTOR] fix code smell * [RED] update topics tests to return quiz * [GREEN] implements read topic also returns quizzes * [REFACTOR] fix code smell * [REFACTOR] fix test * [REFACTOR] fix tests * [REFACTOR] fix tests * [REFACTOR] fix typo and missing code
* [CHORES] Factories, Models, Migrations * [RED] Create Submission * [GREEN] Fix styling * [GREEN] Fix styling * [GREEN] Fix styling * [GREEN] Create Submission Test * [GREEN] Create Submission Test * [GREEN] Create Submission Test * [RED] Read Submission * [GREEN] Read Submission * [GREEN] Read Submission * [RED] Edit Submission * [GREEN] Edit Submission * [GREEN] Edit Submission * [GREEN] Edit Submission
Fathan said "merge aja langsung"
* [CHORE] fix datetime format and attribute naming * [REFACTOR use iso8601 datetime format
* [CHORE] fix datetime format and attribute naming * [REFACTOR use iso8601 datetime format * [REFACTOR] atttribute naming * [REFACTOR] atttribute naming
* [CHORES] Factories, Models, Migrations * [RED] Create Submission * [GREEN] Fix styling * [GREEN] Fix styling * [GREEN] Fix styling * [GREEN] Create Submission Test * [GREEN] Create Submission Test * [GREEN] Create Submission Test * [RED] Read Submission * [GREEN] Read Submission * [GREEN] Read Submission * [RED] Edit Submission * [GREEN] Edit Submission * [GREEN] Edit Submission * [GREEN] Edit Submission * [GREEN] Add id to read response
* [RED] edit delete tests for quiz * [GREEN] implements edit delete for quiz * [REFACTOR] fix typo * [REFACTOR] fix array * [REFACTOR] actually fix array
* Initial commit * Initial commit * Recreate * Write the tech docs * Change package manager from npm to yarn * Test github action * Test on all branches * Test on all branches * specify branch * use yml arrray syntax * match all branches * match all branches * match all branches with */* * match all branches with */* without [] * match all branches with '*/*' * match all branches with aldi/* * Run only on main and staging branch
| @@ -0,0 +1,84 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Untuk auth service, mungkin lebih baik menggunakan Auth API yang disediakan oleh badaso core saja ?
| @@ -0,0 +1,44 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Untuk file management, mungkin lebih baik menggunakan API yang yang disediakan oleh badaso core ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.