Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PBI 31 & 32: edit delete comment #64

Merged
merged 7 commits into from
Apr 24, 2022
Merged

PBI 31 & 32: edit delete comment #64

merged 7 commits into from
Apr 24, 2022

Conversation

kanziebub
Copy link

No description provided.

@kanziebub kanziebub changed the base branch from main to staging April 19, 2022 15:28
AldiNFitrah
AldiNFitrah reviewed Apr 19, 2022
View reviewed changes
Copy link

@AldiNFitrah AldiNFitrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's from me. You did a great job on the robust tests!

src/Controllers/MaterialCommentController.php Outdated Show resolved Hide resolved
src/Controllers/MaterialCommentController.php Outdated Show resolved Hide resolved
@kanziebub kanziebub requested a review from AldiNFitrah April 21, 2022 19:40
FXDROS
FXDROS approved these changes Apr 23, 2022
View reviewed changes
Copy link

@FXDROS FXDROS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!!

nofamex
nofamex approved these changes Apr 23, 2022
View reviewed changes
Copy link
Contributor

@nofamex nofamex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kanziebub kanziebub merged commit 407a807 into staging Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FXDROS FXDROS FXDROS approved these changes

@nofamex nofamex nofamex approved these changes

@IlmaMannix IlmaMannix Awaiting requested review from IlmaMannix

@darren-ngoh darren-ngoh Awaiting requested review from darren-ngoh

@Zsaschz Zsaschz Awaiting requested review from Zsaschz

@AldiNFitrah AldiNFitrah Awaiting requested review from AldiNFitrah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kanziebub @AldiNFitrah @nofamex @FXDROS